[Payments] Desktop: Credit card editor expiration date should be one field |
||||
Issue descriptionRight now fields are separated by year/month, should be one line for the whole date.
,
May 22 2017
,
Jun 27 2017
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75314deec6806d299671666f2b17b61f12d15f07 commit 75314deec6806d299671666f2b17b61f12d15f07 Author: Yoshifumi Inoue <yosin@chromium.org> Date: Tue Oct 24 08:14:43 2017 Introduce IsEmptyWordRange() to SelectionController::SelectClosestWordFromHitTestResult() This patch Introduces |IsEmptyWordRange()| by moving code to simplify |SelectionController::SelectClosestWordFromHitTestResult()| for improving code health. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/724584: ComputeWordAroundPosition() for Layout NG Bug: 724584 Change-Id: Icaaa666816bbd86ac25634723445041359a21b5e Reviewed-on: https://chromium-review.googlesource.com/732871 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#511057} [modify] https://crrev.com/75314deec6806d299671666f2b17b61f12d15f07/third_party/WebKit/Source/core/editing/SelectionController.cpp
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc33f6a2661cc1632657f24f7e8e8282f38c6529 commit bc33f6a2661cc1632657f24f7e8e8282f38c6529 Author: Yoshifumi Inoue <yosin@chromium.org> Date: Tue Oct 24 09:25:37 2017 Introduce FindWordStartBoundary() as replacement of FindWordBoundary() This patch introduces |FindWordStartBoundary()| as replacement of |FindWordStartBoundary()|, which returns both start and end boundaries, however all call sites, actually only one call site, uses only start boundary to simplify source code for improving code health. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/724584: ComputeWordAroundPosition() for Layout NG Bug: 724584 Change-Id: I99af540e934709a7bd977c42a5fa6a31077eb842 Reviewed-on: https://chromium-review.googlesource.com/732864 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#511068} [modify] https://crrev.com/bc33f6a2661cc1632657f24f7e8e8282f38c6529/third_party/WebKit/Source/core/editing/VisibleUnitsWord.cpp [modify] https://crrev.com/bc33f6a2661cc1632657f24f7e8e8282f38c6529/third_party/WebKit/Source/platform/text/TextBoundaries.cpp [modify] https://crrev.com/bc33f6a2661cc1632657f24f7e8e8282f38c6529/third_party/WebKit/Source/platform/text/TextBoundaries.h
,
Oct 25 2017
Tested the issue on windows 10 , Mac OS 10.12.6 , ubuntu 14.04 using chrome M64 #64.0.3249.0 using the following steps : 1. Launched chrome and signed into chrome using google credentials. 2. Navigated to payments.google.com and observed that date fields are in one line for the credit card . Attached screenshot for reference. @Mathp-- Could you please check attached screenshot for reference and confirm us if this is the expected result or if we had missed any steps in verifying the issue. Thanks!
,
Oct 25 2017
This is an old bug, the latest changes don't have anything to do with it (probably a mistake). The original bug referred to the UI attached. Steps to trigger this UI are at go/pr-test |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, May 22 2017