New issue
Advanced search Search tips

Issue 724575 link

Starred by 1 user
Status: Archived
Owner:
x...@chromium.org
Closed: May 2017
Cc:
shibasheikh@chromium.org
weifangsun@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

CUPS: the protocol drop down menu's width in 'manual-add-printer' dialog is incorrect

Project Member Reported by x...@chromium.org, May 19 2017 
Chrome Version: (copy from chrome://version)
OS: Chrome

Please see the attached screenshot. The width of the Protocol dropdown menu should be the same with Address & Queue.
before (1).png
180 KB View Download

Comment 1 by x...@chromium.org, May 22 2017 

See after screenshots.
after (1).png
182 KB View Download

Comment 2 by x...@chromium.org, May 23 2017 

This one might be better. Weifang, what do you think?
after2.png
179 KB View Download

Comment 3 by weifangsun@chromium.org, May 23 2017

Cc: shibasheikh@chromium.org
Hmm, I think I like the first one better actually.

+shibasheikh@ - What do you think?

Comment 4 by x...@chromium.org, May 23 2017 

If we prefer no left white-space padding for the underline of the dropdown list, attached screenshot might be better than the one in comment#1 regarding to the right side padding after the dropdown arrow. What do you think?
after3.png
178 KB View Download

Comment 5 by weifangsun@chromium.org, May 23 2017 

Oh nice! I do like this 3rd option the best. :)
Project Member

Comment 6 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbc8de4d979f168d1f5e7bd8bbf9f561349535c5

commit fbc8de4d979f168d1f5e7bd8bbf9f561349535c5
Author: xdai <xdai@chromium.org>
Date: Thu May 25 18:33:41 2017

CUPS: Fix the incorrect width Protocol drop down menu.

BUG= 724575 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2891423003
Cr-Commit-Position: refs/heads/master@{#474718}

[modify] https://crrev.com/fbc8de4d979f168d1f5e7bd8bbf9f561349535c5/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

Comment 7 by x...@chromium.org, May 25 2017

Status: Fixed (was: Assigned)

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment