New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724567 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

fast/spatial-navigation/snav-z-index.html is flaky

Project Member Reported by jbroman@chromium.org, May 19 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edd966f42e17c86c7658b9e3464838162640e18d

commit edd966f42e17c86c7658b9e3464838162640e18d
Author: jbroman <jbroman@chromium.org>
Date: Fri May 19 18:26:56 2017

Mark fast/spatial-navigation/snav-z-index.html as flaky.

BUG= 724567 
TBR=carlosk@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2898463002
Cr-Commit-Position: refs/heads/master@{#473253}

[modify] https://crrev.com/edd966f42e17c86c7658b9e3464838162640e18d/third_party/WebKit/LayoutTests/TestExpectations

Cc: -carlosk@chromium.org hayato@chromium.org dominicc@chromium.org
My changes were unrelated to the core of spatial navigations. CC-ing a couple members from dom-dev@ as they are marked as owners of spatial-navigation layout tests.

Direct link to the layout tests results from the build linked in the OP: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/9859/layout-test-results/results.html

Comment 3 by tkent@chromium.org, May 26 2017

Components: -Blink>DOM Blink>Focus

Comment 4 by kochi@chromium.org, May 26 2017

Cc: kochi@chromium.org
Owner: kolc...@opera.com
Status: Assigned (was: Untriaged)

Comment 5 by kochi@chromium.org, May 26 2017

Cc: -kochi@chromium.org kolc...@opera.com
Owner: kochi@chromium.org
Looks like kolczyk@ is inactive these days - assigning to myself.

Comment 6 by r...@opera.com, May 29 2017

This seemed to fix the flakiness locally: https://chromium-review.googlesource.com/c/518163/
Project Member

Comment 7 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5c34b46e460fcc5dd288659a3e11c6f290a8c6c

commit e5c34b46e460fcc5dd288659a3e11c6f290a8c6c
Author: Rune Lillesveen <rune@opera.com>
Date: Tue May 30 05:09:08 2017

Fixed flaky test snav-z-index.html.

requestAnimationFrame before initTest().

Without this change, repeat-each=10 caused failures most of the time.
With this change repeat-each=100 has been run locally a few times
without any failures (Linux x64).

Also converted some setTimeout => requestAnimationFrame for better
predictability.

R=kochi@chromium.org
BUG= 724567 

Change-Id: Ic1f27c3fda1ff7da063ab29286d707cb518ab7a6
Reviewed-on: https://chromium-review.googlesource.com/518163
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Rune Lillesveen <rune@opera.com>
Cr-Commit-Position: refs/heads/master@{#475429}
[modify] https://crrev.com/e5c34b46e460fcc5dd288659a3e11c6f290a8c6c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e5c34b46e460fcc5dd288659a3e11c6f290a8c6c/third_party/WebKit/LayoutTests/fast/spatial-navigation/resources/spatial-navigation-utils.js
[modify] https://crrev.com/e5c34b46e460fcc5dd288659a3e11c6f290a8c6c/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html
[modify] https://crrev.com/e5c34b46e460fcc5dd288659a3e11c6f290a8c6c/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-z-index.html

Comment 8 by r...@opera.com, May 30 2017

Owner: r...@opera.com
Status: Fixed (was: Assigned)
Components: Blink>HTML>Focus
Components: -Blink>Focus

Sign in to add a comment