New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724564 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

If block has clearance then container's content_size should be set to block's logical_offset.

Project Member Reported by glebl@chromium.org, May 19 2017

Issue description

This fix should be as simple as adding 2 lines below to NGBlockLayoutAlgorithm::FinishChildLayout

if (child->Style().Clear() != EClear::kNone)
  content_size_ = logical_offset.block_offset + fragment.BlockSize();

affected layout tests

virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-029.xht
virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-144.xht
virtual/layout_ng/external/wpt/css/CSS2/floats-clear/margin-collapse-018.xht
virtual/layout_ng/external/wpt/css/CSS2/floats-clear/margin-collapse-027.xht

 

Comment 1 by glebl@chromium.org, May 25 2017

Owner: lchoi@chromium.org

Sign in to add a comment