Re-enable two visible url tests |
||||||
Issue descriptiontestBackNavigationWithPendingReload and testBackNavigationWithPendingRendererInitiatedNavigation have issues while reloading. Re-enable the tests.
,
May 23 2017
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 23 2017
,
May 31 2017
The two tests are not disabled but modified. Re-evaluate the tests after they run on bots for a while.
,
May 31 2017
The ETS can not respond to a new request before the previous one is completed. These two tests verify receiving of new requests while the server is paused, which fails under ETS. The new requests will be handled after server starts again. Removing the checks do not change the purpose of the tests. We can still verify the new requests after the server is un-paused.
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c9727c3e7c09b51e7590f2cc429580f4a91f968 commit 2c9727c3e7c09b51e7590f2cc429580f4a91f968 Author: huangml <huangml@chromium.org> Date: Wed May 31 22:28:37 2017 Modify visible url tests for embedded test server. The ETS can not respond to a new request before the previous one is completed. These two tests verify receiving of new requests while the server is paused, which fails under ETS. The new requests will be handled after server starts again. Removing the checks do not change the purpose of the tests. We can still verify the new requests after the server is un-paused. Modify the tests and make it run under GCDWebServer on bots first in case we are missing some edge cases. BUG= 724560 Review-Url: https://codereview.chromium.org/2915893002 Cr-Commit-Position: refs/heads/master@{#476064} [modify] https://crrev.com/2c9727c3e7c09b51e7590f2cc429580f4a91f968/ios/chrome/browser/web/visible_url_egtest.mm
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c9727c3e7c09b51e7590f2cc429580f4a91f968 commit 2c9727c3e7c09b51e7590f2cc429580f4a91f968 Author: huangml <huangml@chromium.org> Date: Wed May 31 22:28:37 2017 Modify visible url tests for embedded test server. The ETS can not respond to a new request before the previous one is completed. These two tests verify receiving of new requests while the server is paused, which fails under ETS. The new requests will be handled after server starts again. Removing the checks do not change the purpose of the tests. We can still verify the new requests after the server is un-paused. Modify the tests and make it run under GCDWebServer on bots first in case we are missing some edge cases. BUG= 724560 Review-Url: https://codereview.chromium.org/2915893002 Cr-Commit-Position: refs/heads/master@{#476064} [modify] https://crrev.com/2c9727c3e7c09b51e7590f2cc429580f4a91f968/ios/chrome/browser/web/visible_url_egtest.mm
,
Sep 14 2017
Is this fixed now per comment #7?
,
Jan 24 2018
,
Jan 24 2018
,
May 31 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by huangml@chromium.org
, May 19 2017