New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724551 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Disable URL bar input for the New Tab Page while in VR on Android.

Project Member Reported by mthiesse@chromium.org, May 19 2017

Issue description

We don't support keyboard or microphone at the moment, so to prevent showing 2D UI in VR mode we should just disable the URL bar on the NTP.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8c17ea5f62b4d647f2cb4e892333927d8e37779

commit c8c17ea5f62b4d647f2cb4e892333927d8e37779
Author: mthiesse <mthiesse@chromium.org>
Date: Fri Jun 02 20:54:09 2017

Disable NTP URL bar while in VR on Android.

Unfortunately we don't support keyboard or microphone input while in VR just yet, so we need to disable them to prevent the 2D popups from obscuring VR content.

BUG= 724551 

Review-Url: https://codereview.chromium.org/2891423002
Cr-Commit-Position: refs/heads/master@{#476779}

[modify] https://crrev.com/c8c17ea5f62b4d647f2cb4e892333927d8e37779/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 5 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 5 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69cdab9ff3cb9593b1155a8cbc5edd8f5c4c31c3

commit 69cdab9ff3cb9593b1155a8cbc5edd8f5c4c31c3
Author: Michael Thiessen <mthiesse@google.com>
Date: Mon Jun 05 14:27:19 2017

Disable NTP URL bar while in VR on Android.

Unfortunately we don't support keyboard or microphone input while in VR just yet, so we need to disable them to prevent the 2D popups from obscuring VR content.

BUG= 724551 

Review-Url: https://codereview.chromium.org/2891423002
Cr-Original-Commit-Position: refs/heads/master@{#476779}
Review-Url: https://codereview.chromium.org/2920273002 .
Cr-Commit-Position: refs/branch-heads/3112@{#150}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/69cdab9ff3cb9593b1155a8cbc5edd8f5c4c31c3/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in Chrome Canary 61.0.3124.3

Sign in to add a comment