Issue metadata
Sign in to add a comment
|
Recompilation should be noop after a noop "gn gen" |
||||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Build a target (2) Run "gn gen" or touch <OUT_DIR>/build.ninja (3) Build the target again What is the expected result? It should be noop for the second build. What happens instead? There are still actions. This was discovered when investigating issue 723856.
,
May 23 2017
`gn gen` will change build.ninja if the command line args passed to gen change, because build.ninja records the command used to generate the files. For example `gn gen out/Release && gn gen --ide=json out/Release` will modify build.ninja, because the flags are changing. However, `gn gen out/Release && gn gen out/Release` should not touch build.ninja; if that's happening, that's most likely a bug.
,
May 23 2017
You are right. The case in https://codereview.chromium.org/2891363004/ is different because it gives --ide. This is tracking the later case.
,
May 23 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sergeybe...@chromium.org
, May 22 2017