This issue tracks the introduction of RuntimeCallStats to Blink, in order to measure/monitor run times of the JS bindings layer and certain heavy C++ operations like layout/Oilpan GC. Design doc: https://docs.google.com/document/d/1sJc_9lxiQmCwnpnM6bxBSlNs4iVthmG0PtCk1KRio_M/edit?usp=sharing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93940c28766bb4573dc9f9fdfd6052b36c54651b commit 93940c28766bb4573dc9f9fdfd6052b36c54651b Author: Adithya Srinivasan <adithyas@chromium.org> Date: Fri May 26 01:06:04 2017 Basic implementation of RuntimeCallStats Adds RuntimeCallCounter, RuntimeCallTimer and the basic RuntimeCallStats API to track execution time and counts of functions. Bug: 724543 Change-Id: I45273f65187dd481b394605a75646dd797f605bf Reviewed-on: https://chromium-review.googlesource.com/513886 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#474860} [modify] https://crrev.com/93940c28766bb4573dc9f9fdfd6052b36c54651b/third_party/WebKit/Source/platform/BUILD.gn [add] https://crrev.com/93940c28766bb4573dc9f9fdfd6052b36c54651b/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.cpp [add] https://crrev.com/93940c28766bb4573dc9f9fdfd6052b36c54651b/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h [add] https://crrev.com/93940c28766bb4573dc9f9fdfd6052b36c54651b/third_party/WebKit/Source/platform/bindings/RuntimeCallStatsTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b83adb8cd1eec1b0db28353b9cd106613160915 commit 8b83adb8cd1eec1b0db28353b9cd106613160915 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Mon May 29 19:36:49 2017 Add test counters to RuntimeCallStats - Adds counters to RuntimeCallStats - Updates Enter/Leave to use CounterId instead of RuntimeCallCounter* - Add << overload for RuntimeCallStats Bug: 724543 Change-Id: I238f362a726984a0651975fc0a2a9d2b0a57889c Reviewed-on: https://chromium-review.googlesource.com/516222 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#475374} [modify] https://crrev.com/8b83adb8cd1eec1b0db28353b9cd106613160915/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.cpp [modify] https://crrev.com/8b83adb8cd1eec1b0db28353b9cd106613160915/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h [modify] https://crrev.com/8b83adb8cd1eec1b0db28353b9cd106613160915/third_party/WebKit/Source/platform/bindings/RuntimeCallStatsTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d784aa93332ceb9f916c6b2fac269db6c5a44abc commit d784aa93332ceb9f916c6b2fac269db6c5a44abc Author: Adithya Srinivasan <adithyas@chromium.org> Date: Tue Jun 06 22:43:41 2017 [RuntimeCallStats] Add some counters Adds counters for some core blink tasks like layout, GC, style and paint. Bug: 724543 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0f708887efa6f22ed8bd691fb740a22da15ebb55 Reviewed-on: https://chromium-review.googlesource.com/521384 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#477445} [modify] https://crrev.com/d784aa93332ceb9f916c6b2fac269db6c5a44abc/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/d784aa93332ceb9f916c6b2fac269db6c5a44abc/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp [modify] https://crrev.com/d784aa93332ceb9f916c6b2fac269db6c5a44abc/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/d784aa93332ceb9f916c6b2fac269db6c5a44abc/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/d784aa93332ceb9f916c6b2fac269db6c5a44abc/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.cpp [modify] https://crrev.com/d784aa93332ceb9f916c6b2fac269db6c5a44abc/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h [modify] https://crrev.com/d784aa93332ceb9f916c6b2fac269db6c5a44abc/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp [modify] https://crrev.com/d784aa93332ceb9f916c6b2fac269db6c5a44abc/third_party/WebKit/Source/platform/heap/ThreadState.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec7081e05094e3a9ee1467c21cf66f8c4d23637f commit ec7081e05094e3a9ee1467c21cf66f8c4d23637f Author: Adithya Srinivasan <adithyas@chromium.org> Date: Tue Jun 13 17:35:57 2017 Check isolate before creating RuntimeCallTimerScope Adds a null check for GetIsolate() in PerformIdleLazySweep. Bug: 732785, 724543 Change-Id: Ie805a4ed1243582ba26d6d8c4481901d05fc87ea Reviewed-on: https://chromium-review.googlesource.com/533373 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#479059} [modify] https://crrev.com/ec7081e05094e3a9ee1467c21cf66f8c4d23637f/third_party/WebKit/Source/platform/heap/ThreadState.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3805913a2f5257698eb7bdcff3d56e6cff7f53fe commit 3805913a2f5257698eb7bdcff3d56e6cff7f53fe Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed Jun 14 16:49:42 2017 [RuntimeCallStats] Introduce IDL extended attribute RuntimeStatsCounter Adding [RuntimeStatsCounter=*] to a method or attribute of an IDL interface will add bindings to measure call counts and run times using RuntimeCallStats. This CL also introduces macros in RuntimeCallStats.h to add counters which will be used by the bindings generated for [RuntimeStatsCounter]. Bug: 724543 Change-Id: Iea248b19db6942db16793cbeb25c0d39c843edb8 Reviewed-on: https://chromium-review.googlesource.com/527460 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#479422} [modify] https://crrev.com/3805913a2f5257698eb7bdcff3d56e6cff7f53fe/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md [modify] https://crrev.com/3805913a2f5257698eb7bdcff3d56e6cff7f53fe/third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt [modify] https://crrev.com/3805913a2f5257698eb7bdcff3d56e6cff7f53fe/third_party/WebKit/Source/bindings/scripts/v8_attributes.py [modify] https://crrev.com/3805913a2f5257698eb7bdcff3d56e6cff7f53fe/third_party/WebKit/Source/bindings/scripts/v8_methods.py [modify] https://crrev.com/3805913a2f5257698eb7bdcff3d56e6cff7f53fe/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl [modify] https://crrev.com/3805913a2f5257698eb7bdcff3d56e6cff7f53fe/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl [modify] https://crrev.com/3805913a2f5257698eb7bdcff3d56e6cff7f53fe/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl [modify] https://crrev.com/3805913a2f5257698eb7bdcff3d56e6cff7f53fe/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp [modify] https://crrev.com/3805913a2f5257698eb7bdcff3d56e6cff7f53fe/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h [modify] https://crrev.com/3805913a2f5257698eb7bdcff3d56e6cff7f53fe/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.cpp [modify] https://crrev.com/3805913a2f5257698eb7bdcff3d56e6cff7f53fe/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h [modify] https://crrev.com/3805913a2f5257698eb7bdcff3d56e6cff7f53fe/third_party/WebKit/Source/platform/bindings/RuntimeCallStatsTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4472d90dddda5ed241b09769915d8bde24e8e24 commit b4472d90dddda5ed241b09769915d8bde24e8e24 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Mon Jun 26 18:04:08 2017 [RuntimeCallStats] Add macros for a fast path when RCS is disabled This CL disables RCS by default and only enables it when the --dump-blink-runtime-call-stats flag is specified. Macros are added to wrap Enter, Leave and TimerScope with a global boolean check for a fast path when RCS is disabled. All call sites are replaced with these macros. Counters are also added to some core bindings methods like wrapper creation and to some IDL methods which are heavily used and time-consuming in Speedometer. Bug: 724543 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I22086a6d7b35e02e34e7a2a1a8c114dc948f3937 Reviewed-on: https://chromium-review.googlesource.com/540419 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#482320} [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/bindings/core/v8/ToV8ForCore.cpp [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.cpp [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/core/dom/Element.idl [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/core/events/EventTarget.idl [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/core/frame/WindowTimers.idl [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/core/html/HTMLElement.idl [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.cpp [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/platform/bindings/RuntimeCallStatsTest.cpp [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/platform/bindings/V8DOMWrapper.cpp [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/platform/bindings/V8DOMWrapper.h [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/platform/bindings/V8ValueCache.cpp [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp [modify] https://crrev.com/b4472d90dddda5ed241b09769915d8bde24e8e24/third_party/WebKit/Source/platform/heap/ThreadState.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7e75e43adfb28a47834c7462c2d499b3626de99 commit d7e75e43adfb28a47834c7462c2d499b3626de99 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Thu Jun 29 20:19:22 2017 [RuntimeCallStats] Add trace events for RCS This CL adds macros to wrap existing trace events with a RuntimeCallStats dump when RCS is enabled. A few trace events in V8ScriptRunner are updated to use this macro. Bug: 724543 Change-Id: Idcf71920af2495f337918e8b5987875382fe8ec9 Reviewed-on: https://chromium-review.googlesource.com/546776 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#483465} [modify] https://crrev.com/d7e75e43adfb28a47834c7462c2d499b3626de99/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp [modify] https://crrev.com/d7e75e43adfb28a47834c7462c2d499b3626de99/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.cpp [modify] https://crrev.com/d7e75e43adfb28a47834c7462c2d499b3626de99/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h [modify] https://crrev.com/d7e75e43adfb28a47834c7462c2d499b3626de99/third_party/WebKit/Source/platform/bindings/RuntimeCallStatsTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a46959ccdf34bd61fd516cec7e5b55fbed4fbd5 commit 4a46959ccdf34bd61fd516cec7e5b55fbed4fbd5 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed Jul 05 18:09:07 2017 [RuntimeCallStats] Account for V8 re-entries If we go from V8 -> Blink Callback -> V8, V8 stops measuring time in the FunctionCallback counter (which is categorized under Blink C++) and uses other counters instead. Blink however currently will still continue measuring using the same callback counter creating a situation where the time measured by the callback counter (in Blink RCS) is greater than the total time in the Blink C++ category (in V8 RCS). Since Blink RCS aims to break down the Blink C++ category in V8 RCS, we need to avoid counting time spent in V8. This CL adds a separate V8 counter that will measure time spent in V8 and therefore not count that time in other blink callback counters. This CL also addresses some post commit comments in https://chromium-review.googlesource.com/c/546776/. Bug: 724543 Change-Id: I1158203a3d47c01e821b880e574bf5b52b80b88d Reviewed-on: https://chromium-review.googlesource.com/558157 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#484309} [modify] https://crrev.com/4a46959ccdf34bd61fd516cec7e5b55fbed4fbd5/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp [modify] https://crrev.com/4a46959ccdf34bd61fd516cec7e5b55fbed4fbd5/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h [modify] https://crrev.com/4a46959ccdf34bd61fd516cec7e5b55fbed4fbd5/third_party/WebKit/Source/platform/bindings/V8ObjectConstructor.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2327ca13c5f346e1f03bfe7bf17cb17728316052 commit 2327ca13c5f346e1f03bfe7bf17cb17728316052 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Thu Jul 06 00:16:13 2017 [RuntimeCallStats] Enable Blink RuntimeCallStats in v8.runtime_stats.top_25 Adds a browser option to the V8 Top 25 pages benchmark to dump Blink RCS counters through tracing. 'runtimeStatsMetric' in metrics/v8/runtime_stats_metric.html has already been updated to account for and create histograms for these counters. Bug: 724543 Change-Id: I7c365dd4f6b68a745b5b7b640aa532bba9dd0400 Reviewed-on: https://chromium-review.googlesource.com/558266 Reviewed-by: Fadi Meawad <fmeawad@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#484393} [modify] https://crrev.com/2327ca13c5f346e1f03bfe7bf17cb17728316052/tools/perf/benchmarks/v8.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f47145f491d963103d5e099f17d44e8c83074c9c commit f47145f491d963103d5e099f17d44e8c83074c9c Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed Jul 12 22:44:07 2017 [RuntimeCallStats] Add more counters The counters added here are for methods and attributes that take up a non-trivial portion (4-10%) of time spent doing Blink C++ on some websites from the v8_top25 benchmark. Bug: 724543 Change-Id: Idbab1de4b7128a4a934ca22a7b739c2fa5b035bc Reviewed-on: https://chromium-review.googlesource.com/565682 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486143} [modify] https://crrev.com/f47145f491d963103d5e099f17d44e8c83074c9c/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp [modify] https://crrev.com/f47145f491d963103d5e099f17d44e8c83074c9c/third_party/WebKit/Source/core/dom/Document.idl [modify] https://crrev.com/f47145f491d963103d5e099f17d44e8c83074c9c/third_party/WebKit/Source/core/dom/DocumentFragment.cpp [modify] https://crrev.com/f47145f491d963103d5e099f17d44e8c83074c9c/third_party/WebKit/Source/core/dom/Element.idl [modify] https://crrev.com/f47145f491d963103d5e099f17d44e8c83074c9c/third_party/WebKit/Source/core/dom/Node.idl [modify] https://crrev.com/f47145f491d963103d5e099f17d44e8c83074c9c/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h [modify] https://crrev.com/f47145f491d963103d5e099f17d44e8c83074c9c/third_party/WebKit/Source/platform/bindings/ToV8.h [modify] https://crrev.com/f47145f491d963103d5e099f17d44e8c83074c9c/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49743d172b736ffd619215c32b6eb3e2582b3b80 commit 49743d172b736ffd619215c32b6eb3e2582b3b80 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Thu Jul 13 01:41:01 2017 Roll src/third_party/catapult/ 6c40c273a..1286055c7 (8 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6c40c273a7fe..1286055c7baf $ git log 6c40c273a..1286055c7 --date=short --no-merges --format='%ad %ae %s' 2017-07-12 adithyas Add table for Blink RuntimeCallStats 2017-07-12 bpastene devil: Add a device_utils method to mv-then-rm a device file. 2017-07-12 nednguyen Rename webpagereplay_go.py to webpagereplay_go_server.py 2017-07-12 nednguyen Add WPR go binary for Mac platform 2017-07-12 bpastene devil: When pushing data deps to device, don't mkdir redundantly. 2017-07-12 simonhatch Dashboard - Fix test-picker add button never un-greying 2017-07-12 simonhatch Dashboard - Add api_request_handler 2017-07-12 etienneb Fix symbolisation for address out-of-range Created with: roll-dep src/third_party/catapult BUG= 724543 ,739899,739899, 739783 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I114d56bf15f445060eb48951a120fd99819e0024 Reviewed-on: https://chromium-review.googlesource.com/569138 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486207} [modify] https://crrev.com/49743d172b736ffd619215c32b6eb3e2582b3b80/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2078c830eb9be5e2bbc9ba0df10a58f0e0e016d commit e2078c830eb9be5e2bbc9ba0df10a58f0e0e016d Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Thu Jul 13 16:12:08 2017 Roll src/third_party/catapult/ dac003899..6daeed6d7 (2 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/dac0038997b8..6daeed6d7311 $ git log dac003899..6daeed6d7 --date=short --no-merges --format='%ad %ae %s' 2017-07-13 adithyas Remove Blink_ prefix from counters 2017-07-13 xunjieli [wpr-go] Use nil req.Body as appropriate for outgoing requests in http.Transport.RoundTrip() Created with: roll-dep src/third_party/catapult BUG= 724543 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5323b8aee971a46a37e81103ce6dfa76d41efa6e Reviewed-on: https://chromium-review.googlesource.com/570267 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486402} [modify] https://crrev.com/e2078c830eb9be5e2bbc9ba0df10a58f0e0e016d/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e184eb4114832d101b6cb3cc693a8925cd010f4 commit 0e184eb4114832d101b6cb3cc693a8925cd010f4 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed Jul 19 17:47:36 2017 Add BeginArrayWithNonCopiedName to blink::TracedValue RuntimeCallStats creates TracedValue objects using the same set of strings repeatedly. For this case, it makes sense to not create string copies when adding an entry to a TracedValue. The current TracedValue class defined in third_party/WebKit only has methods that create copies of strings. This CL renames the existing methods to match the base::trace_event::TracedValue method they call, and adds methods that call the versions that do not make copies. Bug: 724543 Change-Id: Ice4582c250247fc6caf1123de260fa0d1861c4bf Reviewed-on: https://chromium-review.googlesource.com/550435 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#487908} [modify] https://crrev.com/0e184eb4114832d101b6cb3cc693a8925cd010f4/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/0e184eb4114832d101b6cb3cc693a8925cd010f4/third_party/WebKit/Source/core/layout/LayoutAnalyzer.cpp [modify] https://crrev.com/0e184eb4114832d101b6cb3cc693a8925cd010f4/third_party/WebKit/Source/platform/instrumentation/tracing/TracedValue.cpp [modify] https://crrev.com/0e184eb4114832d101b6cb3cc693a8925cd010f4/third_party/WebKit/Source/platform/instrumentation/tracing/TracedValue.h [modify] https://crrev.com/0e184eb4114832d101b6cb3cc693a8925cd010f4/third_party/WebKit/Source/platform/instrumentation/tracing/TracedValueTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/430b0c05939518c8cf6e52bf8b8965bcf1d8ddae commit 430b0c05939518c8cf6e52bf8b8965bcf1d8ddae Author: Adithya Srinivasan <adithyas@chromium.org> Date: Thu Jul 27 23:47:21 2017 [RuntimeCallStats] Add counters for GC prologue and epilogue Bug: 724543 Change-Id: Id9f002ab4d0e69317b0d73dd728b191ce596e8a7 Reviewed-on: https://chromium-review.googlesource.com/589727 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#490129} [modify] https://crrev.com/430b0c05939518c8cf6e52bf8b8965bcf1d8ddae/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp [modify] https://crrev.com/430b0c05939518c8cf6e52bf8b8965bcf1d8ddae/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1980ecefd768d2e96a71917545fdfcce5e91c28b commit 1980ecefd768d2e96a71917545fdfcce5e91c28b Author: Adithya Srinivasan <adithyas@chromium.org> Date: Thu Jul 27 23:50:45 2017 [RuntimeCallStats] Move timer scopes into callbacks This CL moves out the timer scopes for IDL methods and attributes into the callbacks to get a more accurate representation of time spent in Blink callbacks. Bug: 724543 Change-Id: I054a77dd8b0013cec8d51c36d668528125c874bd Reviewed-on: https://chromium-review.googlesource.com/589667 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#490135} [modify] https://crrev.com/1980ecefd768d2e96a71917545fdfcce5e91c28b/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl [modify] https://crrev.com/1980ecefd768d2e96a71917545fdfcce5e91c28b/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl [modify] https://crrev.com/1980ecefd768d2e96a71917545fdfcce5e91c28b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd53f6cf990d519979e90ee3c6d446b5a9910d53 commit cd53f6cf990d519979e90ee3c6d446b5a9910d53 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Sat Jul 29 02:07:25 2017 Roll src/third_party/catapult/ 8b13c6e36..5f2552985 (5 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8b13c6e36285..5f255298555b $ git log 8b13c6e36..5f2552985 --date=short --no-merges --format='%ad %ae %s' 2017-07-28 loloangela Fixed errors related to bad-continuation pt.36 2017-07-28 nednguyen cros_browser_backend.IsBrowserRunning return False immediately if cri instance is None 2017-07-28 benjhayden Draw flow events with the correct color. 2017-07-28 adithyas Update Blink RCS Total Time 2017-07-28 jbudorick [devil] Run lsof after mkdir exits with EBUSY. Created with: roll-dep src/third_party/catapult BUG=750243, 724543 ,739899 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I134f7124097572b2b25f135660ee726e29847d66 Reviewed-on: https://chromium-review.googlesource.com/592344 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490581} [modify] https://crrev.com/cd53f6cf990d519979e90ee3c6d446b5a9910d53/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b37ee32ef76eec4108db8ccdb664279ef3e40ba4 commit b37ee32ef76eec4108db8ccdb664279ef3e40ba4 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Tue Aug 15 14:23:31 2017 [RuntimeCallStats] Add counters for all callbacks This patch adds counters to most blink callbacks that are called by V8 during JS execution. This allows us to get a more detailed breakdown of where time is spent executing Blink C++. This is disabled by default. Bug: 724543 Change-Id: I67fd42c8612c7c453630b1fdf0406ce119f3b4c5 Reviewed-on: https://chromium-review.googlesource.com/608880 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#494375} [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/core/v8/GeneratedCodeHelper.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/scripts/v8_attributes.py [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/scripts/v8_interface.py [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/scripts/v8_methods.py [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/scripts/v8_utilities.py [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/bindings/tests/results/modules/V8TestSubObject.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.cpp [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h [modify] https://crrev.com/b37ee32ef76eec4108db8ccdb664279ef3e40ba4/third_party/WebKit/Source/platform/bindings/V8ObjectConstructor.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6c4f0023b6e51d726d7265afc9112cf3396cdfc commit d6c4f0023b6e51d726d7265afc9112cf3396cdfc Author: Adithya Srinivasan <adithyas@chromium.org> Date: Tue Aug 15 16:35:45 2017 [RuntimeCallStats] Add markdown file for RCS Bug: 724543 Change-Id: I488fb592eda1efb17c951bcd3b7e5be6976d9749 Reviewed-on: https://chromium-review.googlesource.com/614094 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#494407} [add] https://crrev.com/d6c4f0023b6e51d726d7265afc9112cf3396cdfc/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db99822501a67f029ff8d22efa12318213c1819d commit db99822501a67f029ff8d22efa12318213c1819d Author: Adithya Srinivasan <adithyas@chromium.org> Date: Tue Aug 15 23:54:45 2017 [RuntimeCallStats] Fix method counters Looks like this escaped my notice in https://chromium-review.googlesource.com/c/608880. Bug: 724543 Change-Id: If493f7a55e108704f1adb1c227c030a8b7f443b3 Reviewed-on: https://chromium-review.googlesource.com/616087 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#494613} [modify] https://crrev.com/db99822501a67f029ff8d22efa12318213c1819d/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl [modify] https://crrev.com/db99822501a67f029ff8d22efa12318213c1819d/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30efd8cc7c4973775af75f5d3a7651717a598017 commit 30efd8cc7c4973775af75f5d3a7651717a598017 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Thu Aug 24 14:12:50 2017 [RuntimeCallStats] Split counters into categories This CLs separates counters into different categories, and adds a prefix in each counter's name based on its category. Bug: 724543 Change-Id: Iaf7a17738eaaa2deb8bd44fb2b4bb9723801ea2d Reviewed-on: https://chromium-review.googlesource.com/628956 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#497033} [modify] https://crrev.com/30efd8cc7c4973775af75f5d3a7651717a598017/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md [modify] https://crrev.com/30efd8cc7c4973775af75f5d3a7651717a598017/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.cpp [modify] https://crrev.com/30efd8cc7c4973775af75f5d3a7651717a598017/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h [modify] https://crrev.com/30efd8cc7c4973775af75f5d3a7651717a598017/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.md [modify] https://crrev.com/30efd8cc7c4973775af75f5d3a7651717a598017/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff5036954209836b3a4f33ba5ac213aaa77be6db commit ff5036954209836b3a4f33ba5ac213aaa77be6db Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Mon Aug 28 17:53:13 2017 Roll src/third_party/catapult/ 21d1c4308..1f8f86306 (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/21d1c4308328..1f8f863067fe $ git log 21d1c4308..1f8f86306 --date=short --no-merges --format='%ad %ae %s' 2017-08-28 adithyas Update runtime_stats_entry to handle Blink RCS categories Created with: roll-dep src/third_party/catapult BUG= 724543 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I898870ab9872f413aae8e7de2343cd57f486834c Reviewed-on: https://chromium-review.googlesource.com/638652 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#497797} [modify] https://crrev.com/ff5036954209836b3a4f33ba5ac213aaa77be6db/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/766faaf9db399af3b4de2a0c88e6aef5c7c2d036 commit 766faaf9db399af3b4de2a0c88e6aef5c7c2d036 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Wed Aug 30 19:21:00 2017 Roll src/third_party/catapult/ db0acc015..8e06404d6 (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/db0acc015b84..8e06404d6939 $ git log db0acc015..8e06404d6 --date=short --no-merges --format='%ad %ae %s' 2017-08-30 adithyas Update runtimeStatsTotalMetric to include Blink RCS Created with: roll-dep src/third_party/catapult BUG= 724543 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I633c12c3f0d557e6e2bd4aea34d92697e58c25cc Reviewed-on: https://chromium-review.googlesource.com/643473 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#498565} [modify] https://crrev.com/766faaf9db399af3b4de2a0c88e6aef5c7c2d036/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a583709d8c7592e8d42747903b17d2b76358f77 commit 1a583709d8c7592e8d42747903b17d2b76358f77 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Fri Sep 01 21:46:12 2017 Enable Blink Runtime Call Stats in v8.runtimestats.browsing_desktop runtimeStatsTotalMetric was updated in https://crrev.com/3003763002 to create histograms for Blink RCS. Bug: 724543 Change-Id: I9a18e73ef3b79bd13eb3e08360d9ef2453caac1a Reviewed-on: https://chromium-review.googlesource.com/646276 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#499315} [modify] https://crrev.com/1a583709d8c7592e8d42747903b17d2b76358f77/tools/perf/benchmarks/v8_browsing.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aaa16508920843174caa160a139b22281893bcff commit aaa16508920843174caa160a139b22281893bcff Author: Adithya Srinivasan <adithyas@chromium.org> Date: Fri Sep 08 13:39:38 2017 [RuntimeCallStats] Add counters for html parsing Adds some more counters to better indicate where time is spent in parsing. Bug: 724543 Change-Id: I7f971b57e34f66e549dfa3c3ad356eede464fe40 Reviewed-on: https://chromium-review.googlesource.com/655817 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#500579} [modify] https://crrev.com/aaa16508920843174caa160a139b22281893bcff/third_party/WebKit/Source/core/dom/ContainerNode.cpp [modify] https://crrev.com/aaa16508920843174caa160a139b22281893bcff/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp [modify] https://crrev.com/aaa16508920843174caa160a139b22281893bcff/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp [modify] https://crrev.com/aaa16508920843174caa160a139b22281893bcff/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp [modify] https://crrev.com/aaa16508920843174caa160a139b22281893bcff/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c62ec906f74f89a7cbb7b3b297c5d9d165dde7f6 commit c62ec906f74f89a7cbb7b3b297c5d9d165dde7f6 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Tue Oct 10 22:17:49 2017 [RuntimeCallStats] Add counter for Node::nodeName While the RCS counter for SetReturnValueFromStringSlow lets us monitor the performance of the slow path in StringCache, we don't really have a way of tracking improvements/regressions in the fast path, and the string conversion process overall. nodeName calls SetReturnValueFromString and is called by a large number of sites in the v8 top_25 page set, and is a good way to monitor improvements here. Bug: 724543 Change-Id: I232391aa19b032aebcf24d95b176ff33a1c74f76 Reviewed-on: https://chromium-review.googlesource.com/709775 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#507794} [modify] https://crrev.com/c62ec906f74f89a7cbb7b3b297c5d9d165dde7f6/third_party/WebKit/Source/core/dom/Node.idl [modify] https://crrev.com/c62ec906f74f89a7cbb7b3b297c5d9d165dde7f6/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e9f822a3530e2ae97d0d04e80178ef6a356f24a commit 0e9f822a3530e2ae97d0d04e80178ef6a356f24a Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed Oct 11 13:48:42 2017 Enable Blink RCS for v8.runtimestats.browsing_mobile The desktop version has had Blink RCS enabled for a month and seems to be stable, so enabling this on mobile now. Bug: 724543 Change-Id: I47c576160d10744f3cb482021b849ff5aa2f983f Reviewed-on: https://chromium-review.googlesource.com/709958 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#507969} [modify] https://crrev.com/0e9f822a3530e2ae97d0d04e80178ef6a356f24a/tools/perf/benchmarks/v8_browsing.py
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/abe8e829a2e9c76e996110ff0aa11fecdb9bf146 commit abe8e829a2e9c76e996110ff0aa11fecdb9bf146 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Mon Jan 08 15:52:12 2018 Create separate histograms for individual counters from Blink RCS https://crrev.com/c/793154 removed histograms for individual counters from both Blink and V8 runtime call stats. There aren't that many blink counters and we find it useful to track the individual counters for performance optimizations, so this CL readds histograms for individual counters from Blink. Bug: chromium:724543 Change-Id: Iafaef4566311a778c634e804be920058d509e54c Reviewed-on: https://chromium-review.googlesource.com/827981 Reviewed-by: Ben Hayden <benjhayden@chromium.org> Reviewed-by: lpy <lpy@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> [modify] https://crrev.com/abe8e829a2e9c76e996110ff0aa11fecdb9bf146/tracing/tracing/metrics/v8/runtime_stats_metric_test.html [modify] https://crrev.com/abe8e829a2e9c76e996110ff0aa11fecdb9bf146/tracing/tracing/metrics/v8/runtime_stats_metric.html
Aside: Probably safe to mark this as Fixed at some point. :)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfd2688b6f523ae07f7c4dd7f730f81c93ba8b1e commit bfd2688b6f523ae07f7c4dd7f730f81c93ba8b1e Author: Adithya Srinivasan <adithyas@chromium.org> Date: Fri Nov 02 17:14:56 2018 [RuntimeCallStats] Add includes for RCS_COUNT_EVERYTHING Bug: 724543 Change-Id: If4da5b51ad6886063801b6e224a0acedd57995cc Reviewed-on: https://chromium-review.googlesource.com/c/1314612 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#604967} [modify] https://crrev.com/bfd2688b6f523ae07f7c4dd7f730f81c93ba8b1e/third_party/blink/renderer/platform/bindings/runtime_call_stats.h
Comment 1 by bugdroid1@chromium.org
, May 26 2017