New issue
Advanced search Search tips

Issue 724542 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 418266
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Beforeunload refresh confirmation causing false "Page Unresponsive" message

Reported by vbgu...@gmail.com, May 19 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Steps to reproduce the problem:
1. Load a page which has JavaScript which implements the beforeunload event.
2. Refresh the page and press enter on the Reload button.  (The issue does not happen if you click the button with the mouse).
3. Wait a second after the page has been reloaded and the Page Unresponsive message will appear.  This dialog disappears automatically if you move your mouse over the page.

What is the expected behavior?
Not to see the Page Unresponsive message after refreshing.

What went wrong?
The Page Unresponsive message appears after refreshing.

Did this work before? N/A 

Chrome version: 58.0.3029.110  Channel: stable
OS Version: 6.3
Flash Version:
 
BeforeUnload.zip
1.1 KB Download

Comment 1 by vbgu...@gmail.com, May 19 2017

Additional information: the issue does not happen while the web inspector is open.
Components: -Blink Blink>DOM
Labels: -Type-Bug -Pri-2 M-59 OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: a...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on windows 7,Ubuntu 14.04 and Mac 10.12.4 using chrome version 58.0.3029.110  and this is working fine on canary 60.0.3111.0 .
Please find the reverse bisect information as below

Narrow Bisect::
Good::59.0.3043.0  ---     (build revision 457297)
Bad::59.0.3042.0  ---     (build revision 456934)

Change Log::
https://chromium.googlesource.com/chromium/src/+log/5e8b5e6aebcb564897e311ae4f4397eed3555457..2d7d2c3632187e2cfaaa5c6ec26d3adb3ae784b0

Possible CL that fixed this issue
https://chromium.googlesource.com/chromium/src/+/2d7d2c3632187e2cfaaa5c6ec26d3adb3ae784b0

avi@ Could you please check and merge this to M58 if it is a valid candidate.

Thanks,

Comment 4 by a...@chromium.org, May 26 2017

Are you really sure?

1. That's a big change and I'm scared to merge it to M58.
2. M59 already has this fix, and it's going to stable in a week and half (see https://chromepmo.appspot.com/calendar).
3. Will there really be a re-spin of M58 with less than two weeks left?

Comment 5 by a...@chromium.org, May 26 2017

Cc: gov...@chromium.org
Krishna Govind, you own M58. WDYT?

Comment 6 by gov...@chromium.org, May 26 2017

We're not planning any further M58 Stable releases.

Comment 7 by a...@chromium.org, May 26 2017

Mergedinto: 418266
Status: Duplicate (was: Assigned)
Given that we're not doing any further M58 releases, that this is a big change (and relies on an even bigger change), and that M59, which works fine, is less than two weeks away, I have to dup this into the bug for the change.

Reporter, thank you for reporting this. It's a great bug report, with full repro instructions; I wish all bug reports were of this quality. Hang on for two more weeks for your fix to hit stable :)

Comment 8 by vbgu...@gmail.com, May 27 2017

Awesome!
Thanks for the feedback and all of the great work of this community!
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df421e877181f53cf6e5aeb1611f88766efc3f5c

commit df421e877181f53cf6e5aeb1611f88766efc3f5c
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Thu Jun 01 17:25:19 2017

Add RCS to V8PerIsolateData and cmdline switch

- Adds an instance of RCS to V8PerIsolateData
- Logs RCS table in RenderThread::Shutdown (behind a flag)

Bug:  724542 
Change-Id: I496c76c4e79ba5011b90b512c2bd02cd5b6056a2
Reviewed-on: https://chromium-review.googlesource.com/517562
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476337}
[modify] https://crrev.com/df421e877181f53cf6e5aeb1611f88766efc3f5c/content/public/common/content_switches.cc
[modify] https://crrev.com/df421e877181f53cf6e5aeb1611f88766efc3f5c/content/public/common/content_switches.h
[modify] https://crrev.com/df421e877181f53cf6e5aeb1611f88766efc3f5c/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/df421e877181f53cf6e5aeb1611f88766efc3f5c/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.cpp
[modify] https://crrev.com/df421e877181f53cf6e5aeb1611f88766efc3f5c/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h
[modify] https://crrev.com/df421e877181f53cf6e5aeb1611f88766efc3f5c/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.h
[modify] https://crrev.com/df421e877181f53cf6e5aeb1611f88766efc3f5c/third_party/WebKit/Source/web/WebKit.cpp
[modify] https://crrev.com/df421e877181f53cf6e5aeb1611f88766efc3f5c/third_party/WebKit/public/web/WebKit.h

Comment 10 by vbgu...@gmail.com, Jun 7 2017

I received the updated today and verified that this is fixed. Thanks for all of your help!

Sign in to add a comment