New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724526 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: cr50: Update Cr50 firmware from FSI.

Project Member Reported by hungte@chromium.org, May 19 2017

Issue description

Chrome Version: ToT
OS: Chrome

We may need a pytest to update Cr50 firmware explicitly. It should accept firmware from few different locations (which can be specified from args).

 1. Mount release rootfs and find firmware from there.
 2. Allow a firmware blob inside toolkit.

Traditionally updating Cr50 need to stop trunksd, which may crash running Chrome. ToT has new trunks_send ( see https://chromium-review.googlesource.com/#/c/505459/ ) so I think the pytest should use it to update.
 
Cc: josa...@chromium.org ppichai@google.com
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/6331c6ba989c85b185d688318bb3606ce14dab06

commit 6331c6ba989c85b185d688318bb3606ce14dab06
Author: Peter Shih <pihsun@chromium.org>
Date: Mon May 22 14:24:03 2017

pytests: Add pytest to update Cr50 firmware.

Add a pytest that can be used to force update the firmware of Cr50.

The firmware would come from either the release rootfs on DUT (default),
or from a specified path if dargs={'from_release': False,
'firmware_file': '...'} is set.

A RebootStep() should be added after this pytest to complete the update.

BUG= chromium:724526 
TEST=make test

Change-Id: I24fe65e070e673f626c8895dae72499e107a10b6
Reviewed-on: https://chromium-review.googlesource.com/509602
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[add] https://crrev.com/6331c6ba989c85b185d688318bb3606ce14dab06/py/test/pytests/update_cr50_firmware.py

Comment 3 by hungte@chromium.org, Jul 26 2017

Status: Verified (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 18 2017

Labels: merge-merged-factory-gru-9017.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/e9f3f8b7f73a22f1ebd4a3e52b3a3a3c0db097fd

commit e9f3f8b7f73a22f1ebd4a3e52b3a3a3c0db097fd
Author: Peter Shih <pihsun@chromium.org>
Date: Fri Aug 18 02:19:30 2017

pytests: Add pytest to update Cr50 firmware.

Add a pytest that can be used to force update the firmware of Cr50.

The firmware would come from either the release rootfs on DUT (default),
or from a specified path if dargs={'from_release': False,
'firmware_file': '...'} is set.

A RebootStep() should be added after this pytest to complete the update.

BUG= chromium:724526 
TEST=make test

Original-Change-Id: I24fe65e070e673f626c8895dae72499e107a10b6
Original-Reviewed-on: https://chromium-review.googlesource.com/509602
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

Change-Id: I84d384f1ce4947f8bb7b988fd13ba78e97ff5b4e
Reviewed-on: https://chromium-review.googlesource.com/616521
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Commit-Queue: Marco Chen <marcochen@chromium.org>
Tested-by: Marco Chen <marcochen@chromium.org>

[add] https://crrev.com/e9f3f8b7f73a22f1ebd4a3e52b3a3a3c0db097fd/py/test/pytests/update_cr50_firmware.py

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 14 2018

Labels: merge-merged-factory-reef-8811.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/155c2e9037e02468b6d9aa325c71e7f2a7e7e118

commit 155c2e9037e02468b6d9aa325c71e7f2a7e7e118
Author: Peter Shih <pihsun@chromium.org>
Date: Wed Mar 14 09:43:53 2018

pytests: Add pytest to update Cr50 firmware.

Add a pytest that can be used to force update the firmware of Cr50.

The firmware would come from either the release rootfs on DUT (default),
or from a specified path if dargs={'from_release': False,
'firmware_file': '...'} is set.

A RebootStep() should be added after this pytest to complete the update.

BUG= chromium:724526 
TEST=make test

Original-Change-Id: I24fe65e070e673f626c8895dae72499e107a10b6
Original-Reviewed-on: https://chromium-review.googlesource.com/509602
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

Change-Id: I84d384f1ce4947f8bb7b988fd13ba78e97ff5b4e
Reviewed-on: https://chromium-review.googlesource.com/616521
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Commit-Queue: Marco Chen <marcochen@chromium.org>
Tested-by: Marco Chen <marcochen@chromium.org>
(cherry picked from commit e9f3f8b7f73a22f1ebd4a3e52b3a3a3c0db097fd)
Reviewed-on: https://chromium-review.googlesource.com/961175
Reviewed-by: Marco Chen <marcochen@chromium.org>

[add] https://crrev.com/155c2e9037e02468b6d9aa325c71e7f2a7e7e118/py/test/pytests/update_cr50_firmware.py

Sign in to add a comment