Update row should not show multiple buttons |
||||||
Issue descriptionVersion: 59.0.3071.35 dev OS: Chrome See screenshot, the About page got into a state where multiple buttons are being shown.
,
Jun 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/038795765171270a268fde65453f5af66d914061 commit 038795765171270a268fde65453f5af66d914061 Author: stevenjb <stevenjb@chromium.org> Date: Sat Jun 03 02:28:51 2017 Settings: About: Fix restart and powerwash button visibility Currently if |currentChannel_| changes after |targetChannel_| computeShowRelaunchAndPowerwash_() will not get called and the button visibility may be incorrect. Instead of fixing the computeShowRelaunchAndPowerwash_() params, update visibity for both in updateShowRelaunch_() so that they stay in sync. BUG= 724518 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2916383002 Cr-Commit-Position: refs/heads/master@{#476867} [modify] https://crrev.com/038795765171270a268fde65453f5af66d914061/chrome/browser/resources/settings/about_page/about_page.js
,
Jun 5 2017
,
Jun 5 2017
,
Jun 5 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a25746de2eb3e28e64aedd114f78902d084b0474 commit a25746de2eb3e28e64aedd114f78902d084b0474 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Jun 05 17:26:21 2017 Settings: About: Fix restart and powerwash button visibility Currently if |currentChannel_| changes after |targetChannel_| computeShowRelaunchAndPowerwash_() will not get called and the button visibility may be incorrect. Instead of fixing the computeShowRelaunchAndPowerwash_() params, update visibity for both in updateShowRelaunch_() so that they stay in sync. BUG= 724518 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2916383002 Cr-Original-Commit-Position: refs/heads/master@{#476867} Review-Url: https://codereview.chromium.org/2923003002 . Cr-Commit-Position: refs/branch-heads/3112@{#156} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/a25746de2eb3e28e64aedd114f78902d084b0474/chrome/browser/resources/settings/about_page/about_page.js
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by steve...@chromium.org
, Jun 2 2017