New issue
Advanced search Search tips

Issue 724501 link

Starred by 16 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

don't show accessibility icon for tap dragging

Project Member Reported by mbw@google.com, May 19 2017

Issue description

Chrome Version: 59.0.3071.57 (Official Build) beta (64-bit)
Chrome OS Version: 9460.42.0 (Official Build) beta-channel tricky
Chrome OS Platform: Dell Chromebox
<b>Network info: <network, encryption type, router model (if known)></b>

Steps To Reproduce:
(1) Enable tap dragging in settings on laptop
(2) Upgrade Chromebox to latest beta

Expected Result:
No change.

Actual Result:
Wonder why there's a little accessibility person icon next to my profile picture in the tray.

Should tap dragging be moved out of accessibility perhaps?  https://bugs.chromium.org/p/chromium/issues/detail?id=164273
 
Components: UI>Accessibility
Labels: M-59
Components: -UI>Accessibility UI>Shell>Shelf
Labels: Proj-MaterialDesign-CrOS
Status: Untriaged (was: Unconfirmed)
Cc: minch@chromium.org
Owner: tbuck...@chromium.org
Tap dragging was moved into the system menu a11y submenu (issue 632107), and we show the a11y icon in the tray if at least one a11y feature in this menu is enabled, which is why you are seeing this icon.

Handing over to +tbuckley@ to decide what should be done here.
Components: -UI>Shell>Shelf UI>Accessibility UI>Shell>StatusArea

Comment 5 by willg...@gmail.com, Jul 7 2017

Friendly ping on this. The tiny little man icon has overstayed his welcome in the status area.
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 14 2017

Labels: Hotlist-Google
Status: Assigned (was: Untriaged)

Comment 8 by 77bela...@gmail.com, Oct 11 2017

Any updates on this? Still seeing this issue on Chrome 61
This is actually two separate issues;

The 1st being that Tap-dragging appears under both "Device>Touchpad" and the "Accessibility" settings. Having it feature under both sets of options is both confusing and unnecessary. I, like many other users, do not see "tap dragging" as an accessibility option but as a touch pad preference.

The 2nd issue is that ChromeOS does not respect the "Show accessibility options in the system menu" option. Checking this option should remove the little man regardless of what options you have selected under accessibility, but it does not.

Correcting either of these items would fix this issue for the majority of users.
Re 1st issue -- we will look into showing the setting only under "Device>Touchpad"; there are historical reasons we had it under Accessibility.

Re 2nd issue -- the toggle is "*Always* show accessibility options in the system menu". We currently will show it if any a11y settings are enabled to give users quick access to disable features, regardless of the toggle. The toggle to always show the options is so that the row doesn't disappear once a feature is disabled, eg. for users who frequently toggle high-contrast on/off.
Ping? There's some extra code in //ash that we could remove if tap-dragging wasn't considered an a11y feature.

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/827225bb7a05daa16d81e3d523cec30415281eb9

commit 827225bb7a05daa16d81e3d523cec30415281eb9
Author: James Cook <jamescook@chromium.org>
Date: Thu Mar 22 19:28:44 2018

cros: Remove "Tap dragging" accessibility settings

The setting already exists in Settings > Device > Touchpad and it's
confusing that it's in 2 places. It's also confusing that it causes
the accessibility person icon to appear in the status area.

* Remove the checkbox from a11y settings
* Update the a11y settings link to touchpad settings to mention
  tap dragging
* Take tap dragging out of system tray a11y submenu
* Don't show the a11y icon when tap dragging is enabled

Because webui settings are not available at the signin screen
the user will have to sign in before changing tap dragging. This
is consistent with other touchpad settings.

Bug:  164273 ,  724501 
Test: ash_unittests and a11y browser_tests
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I65031173da7cab7e3f5dfc5efde98ec29fa625db
Reviewed-on: https://chromium-review.googlesource.com/971301
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545200}
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/ash/accessibility/accessibility_controller_unittest.cc
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/ash/system/tray_accessibility.cc
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/ash/system/tray_accessibility.h
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/ash/system/tray_accessibility_unittest.cc
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/ash/touch/touch_devices_controller.cc
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/ash/touch/touch_devices_controller.h
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/ash/touch/touch_devices_controller_unittest.cc
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/chrome/app/settings_strings.grdp
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/tools/metrics/actions/actions.xml

Status: Fixed (was: Assigned)
The change seems to have stuck.

This has been marked as 'fixed', but I'm still seeing the Accessibility icon in my dock with tap dragging enabled on Beta 67. Any clarification on this?

Sign in to add a comment