New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724493 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Ink is displayed on Most Visited tiles

Project Member Reported by gambard@chromium.org, May 19 2017

Issue description

On Content Suggestions the ink is displayed when a Most Visited tiles is selected.
This is a MDC bug: if the ink is hidden, the user cannot interact with the cell anymore.
MDC issue: https://github.com/material-components/material-components-ios/issues/1446
 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee559102b866a30486a95ffc7b30f9547c007eb1

commit ee559102b866a30486a95ffc7b30f9547c007eb1
Author: gambard <gambard@chromium.org>
Date: Tue Jun 06 15:37:22 2017

Hide the ink for the custom-design cells

The custom designed cells, like the most visited tiles should not have ink
displayed during interaction.

BUG= 724493 

Review-Url: https://codereview.chromium.org/2927563002
Cr-Commit-Position: refs/heads/master@{#477295}

[modify] https://crrev.com/ee559102b866a30486a95ffc7b30f9547c007eb1/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Cc: gambard@chromium.org
Owner: ----
Owner: gambard@chromium.org
Status: Started (was: ExternalDependency)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d57638fdda374318c746e30f29ab35e4b1a7066f

commit d57638fdda374318c746e30f29ab35e4b1a7066f
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Sep 12 16:23:02 2017

Hides the ink using dedicated method

To hide the ink on the empty items, ContentSuggestions was using a
transparent color for the ink instead of not starting the animation due
to an MDC bug. As the bug is fixed, the correct method can be used.

Bug:  724493 
Change-Id: Id4a63ddcc9977b9c017f882bcf17c2a026ee13b2
Reviewed-on: https://chromium-review.googlesource.com/663340
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501300}
[modify] https://crrev.com/d57638fdda374318c746e30f29ab35e4b1a7066f/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Status: Fixed (was: Started)
To verify:
1. Open ContentSuggestions
2. Tap/Long press on a Most Visited tile

No ink should be displayed (same behavior as now).

Sign in to add a comment