Issue metadata
Sign in to add a comment
|
V8InProcessShutdownWithHungRequest flaky on a cronet bot |
||||||||||||||||||||
Issue descriptionExamples: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Builder%20%28dbg%29/builds/4984 https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Builder%20%28dbg%29/builds/4972 Let me revert the change that introduced it recently
,
May 19 2017
revert landed, but for some reason the cronet bot is sitting idle..
,
May 19 2017
This builder https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Builder%20%28dbg%29 is running on the same physical slave https://build.chromium.org/p/chromium.android/buildslaves/build69-b1 as few other cronet builders.
,
May 22 2017
Misha: What's the current incantation to build net_unittests the same way as the cronet builders? Thanks!
,
May 22 2017
Sorry for delay, as you've discovered it is to use 'cr_cronet.py gn' to generate project with cronet-specific configuration, and afterwards use 'normal' android / chrome tools to build and run net_unittests.
,
May 22 2017
Thanks for the help, Misha! Of course, now I can't repro the crash locally. :( Don't suppose there's some way to get symbolized crash traces from the bots?
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93be9ca690ac29ad965a7f7bf6f899cf05c0c582 commit 93be9ca690ac29ad965a7f7bf6f899cf05c0c582 Author: mmenke <mmenke@chromium.org> Date: Tue May 23 16:29:13 2017 Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder. This adds URLRequestContextBuilderV8, which can construct a URLRequestContext using either type of ProxyResolver. When using such a resolver, the ProxyService will fetch requests using the URLRequestContext that was created with the builder. Added a subclass instead of modifying URLRequestContextBuilder so it can continue to be used without depending on V8. This was originally landed in https://codereview.chromium.org/2881613002/, and reverted in https://codereview.chromium.org/2888043008/. This version of the CL fixes a test-only lifetime issue. BUG= 717253 , 724471 Review-Url: https://codereview.chromium.org/2898073002 Cr-Commit-Position: refs/heads/master@{#473933} [modify] https://crrev.com/93be9ca690ac29ad965a7f7bf6f899cf05c0c582/net/BUILD.gn [modify] https://crrev.com/93be9ca690ac29ad965a7f7bf6f899cf05c0c582/net/proxy/proxy_script_fetcher_impl_unittest.cc [modify] https://crrev.com/93be9ca690ac29ad965a7f7bf6f899cf05c0c582/net/proxy/proxy_service_mojo_unittest.cc [add] https://crrev.com/93be9ca690ac29ad965a7f7bf6f899cf05c0c582/net/proxy/test_mojo_proxy_resolver_factory.cc [add] https://crrev.com/93be9ca690ac29ad965a7f7bf6f899cf05c0c582/net/proxy/test_mojo_proxy_resolver_factory.h [modify] https://crrev.com/93be9ca690ac29ad965a7f7bf6f899cf05c0c582/net/test/embedded_test_server/http_request.cc [add] https://crrev.com/93be9ca690ac29ad965a7f7bf6f899cf05c0c582/net/test/embedded_test_server/simple_connection_listener.cc [add] https://crrev.com/93be9ca690ac29ad965a7f7bf6f899cf05c0c582/net/test/embedded_test_server/simple_connection_listener.h [modify] https://crrev.com/93be9ca690ac29ad965a7f7bf6f899cf05c0c582/net/url_request/url_request_context_builder.cc [modify] https://crrev.com/93be9ca690ac29ad965a7f7bf6f899cf05c0c582/net/url_request/url_request_context_builder.h [add] https://crrev.com/93be9ca690ac29ad965a7f7bf6f899cf05c0c582/net/url_request/url_request_context_builder_v8.cc [add] https://crrev.com/93be9ca690ac29ad965a7f7bf6f899cf05c0c582/net/url_request/url_request_context_builder_v8.h [add] https://crrev.com/93be9ca690ac29ad965a7f7bf6f899cf05c0c582/net/url_request/url_request_context_builder_v8_unittest.cc
,
May 23 2017
,
May 23 2017
Oh, and Pasko: I didn't weigh in earlier, but reverting was the right choice, inconvenient though it may be. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by pasko@chromium.org
, May 19 2017