New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----

Blocking:
issue 715077



Sign in to add a comment

Rename `requireUserMediation` to `preventSilentAccess` in Credential Management API

Project Member Reported by jdoerrie@chromium.org, May 19 2017

Issue description

IMPORTANT:
- This launch issue is used for standards and implementation tracking only.
It is NOT for Chrome approval regarding privacy, security, legal, UI,
testing,
accessibility etc.
- An overview of the different launch issues can be found here:
http://bit.ly/2ncKZfp
- If your feature requires security / privacy / etc approval then seek a PM
to guide you through the go/newchromefeature process

See http://www.chromium.org/blink#launch-process for an overview of the
Blink launch process, but note this doesn't cover security / privacy / etc
reviews as discussed above.

----------

Change description:
This change renames `CredentialsContainer::requireUserMediation` to `CredentialsContainer::preventSilentAccess` in the Credential Management API.

Changes to API surface:
- Introduce `CredentialsContainer::preventSilentAccess`
- Deprecate `CredentialsContainer::requireUserMediation`

Links:
Public standards discussion: https://github.com/w3c/webappsec-credential-management/issues/74
GitHub Pull Request: https://github.com/w3c/webappsec-credential-management/pull/84

Support in other browsers:
Internet Explorer: NA
Firefox: NA
Safari: NA
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d

commit 2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d
Author: vasilii <vasilii@chromium.org>
Date: Thu May 25 13:59:16 2017

Rename requireUserMediation to preventSilentAccess in the CM API.

Pull request for the spec: https://github.com/w3c/webappsec-credential-management/pull/84
Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TZ1wr5BJ0Uk

BUG= 724464 
NOTRY=true

Review-Url: https://codereview.chromium.org/2895243002
Cr-Commit-Position: refs/heads/master@{#474640}

[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/components/password_manager/content/browser/credential_manager_impl.cc
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/components/password_manager/content/browser/credential_manager_impl.h
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/components/password_manager/content/browser/credential_manager_impl_unittest.cc
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/components/password_manager/content/common/credential_manager.mojom
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/components/password_manager/content/renderer/credential_manager_client.cc
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/components/password_manager/content/renderer/credential_manager_client.h
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/components/password_manager/core/browser/credential_manager_logger.cc
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/components/password_manager/core/browser/credential_manager_logger.h
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/components/password_manager/core/browser/credential_manager_logger_unittest.cc
[add] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/components/password_manager/core/browser/credential_manager_pending_prevent_silent_access_task.cc
[rename] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/components/password_manager/core/browser/credential_manager_pending_prevent_silent_access_task.h
[delete] https://crrev.com/a23b4bac4b5965383eb17f8c9942ac40e58fdf3e/components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.cc
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/content/shell/test_runner/mock_credential_manager_client.cc
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/content/shell/test_runner/mock_credential_manager_client.h
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https.html
[add] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-preventsilentaccess-basics.html
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/iframed-credentialscontainer.html
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerClient.cpp
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerClient.h
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainerTest.cpp
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/third_party/WebKit/public/platform/WebCredentialManagerClient.h
[modify] https://crrev.com/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d/tools/metrics/histograms/enums.xml

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3db5b2df2ea7a18e4bbd0c5a61ae9fb33551f54

commit e3db5b2df2ea7a18e4bbd0c5a61ae9fb33551f54
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Nov 21 09:22:49 2017

Remove CredentialsContainer.requireUserMediation

This change removes CredentialsContainer.requireUserMediation in favor
of CredentialsContainer.preventSilentAccess. This feature was deprecated
in M60 and slanted for removal in M62.

Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/TZ1wr5BJ0Uk/1NUDJOSUCAAJ

Bug:  724464 
Change-Id: I5ab2334733c4b8ab9f67af1c66de5f666d205719
Reviewed-on: https://chromium-review.googlesource.com/779195
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518189}
[delete] https://crrev.com/fb36b1f8a3ca55ed90eec369f2b6f0fc37b3bf0d/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html
[modify] https://crrev.com/e3db5b2df2ea7a18e4bbd0c5a61ae9fb33551f54/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e3db5b2df2ea7a18e4bbd0c5a61ae9fb33551f54/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e3db5b2df2ea7a18e4bbd0c5a61ae9fb33551f54/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/e3db5b2df2ea7a18e4bbd0c5a61ae9fb33551f54/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
[modify] https://crrev.com/e3db5b2df2ea7a18e4bbd0c5a61ae9fb33551f54/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h
[modify] https://crrev.com/e3db5b2df2ea7a18e4bbd0c5a61ae9fb33551f54/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl
[modify] https://crrev.com/e3db5b2df2ea7a18e4bbd0c5a61ae9fb33551f54/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/e3db5b2df2ea7a18e4bbd0c5a61ae9fb33551f54/tools/metrics/histograms/enums.xml

Sign in to add a comment