Replace AudioFifo with a deque of AudioBus in AudioTrackRecorder::AudioEncoder |
|
Issue descriptionCurrently, an AudioFifo is used in AudioTrackRecorder::AudioEncoder to store AudioBus elements that involves needless data copy. This AudioFifo can be replaced with a deque of AudioBus to avoid this data copy.
,
May 23 2017
Created https://codereview.chromium.org/2901513002/ with the additional change being addition of audio_bus->Zero(); in AudioEncoder::ProvideInput(...) irrespective of the queue being empty or not. This fixes content_browsertests failures due to uninitialized memory access. Both linux_chromium_msan_rel_ng, linux_chromium_chromeos_msan_rel_ng trybots are green now. miu@, mcasas@: The other issue related to time out is not reproducible locally on linux OS. Also, I am not able to find the trybot for Win7 Tests (dbg)(1) to trigger a dry run. How do I verify the same? Your inputs please on this?
,
Feb 7 2018
What's the situation re. this bug? |
|
►
Sign in to add a comment |
|
Comment 1 by c.pa...@samsung.com
, May 19 2017