New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724447 link

Starred by 3 users
Status: Archived
Owner:
est...@chromium.org
Closed: May 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
tbuck...@chromium.org
█ tdander...@chromium.org
est...@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessary dots is seen for User email with 15 characters and more in Uber tray.

Project Member Reported by mmanchala@chromium.org, May 19 2017 
Chrome Version: 60.0.3102.0/9565.0.0 dev-channel Paine,Kip and Blaze
OS: Chrome

Pre-Condition : Login with user which have 15 characters(For Example; manisha.mnani91)

What steps will reproduce the problem?
(1)Sign into user -> click on Uber Tray and now observe User email id (Please refer screenshot)

Expected: No dots should be seen for User email even there is required space i.e. entire Id should be seen (manisha.mnani91@gmail.com)
Actual: Instead Unnecessary dots is seen for User email which have 15 characters i.e. 'manisha.mnani91@gmail.co...' is seen 

This is Regression issue as same is working fine in 60.0.3077.0/9483.0.0
dev-channel Paine

@tbuckley : Please confirm the Issue
Actual_UserEmailid.jpg
409 KB View Download
Expected_UserEmailid.jpg
328 KB View Download

Comment 1 by tbuck...@chromium.org, May 26 2017

Cc: tdander...@chromium.org tbuck...@chromium.org
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Owner: est...@chromium.org
@estade it looks like we're being too aggressive with ellipsizing. Do we allow the email string to extend to the edge of the clickable area?

Removing as stable-blocker, this is pretty minor.

Comment 2 by tdander...@chromium.org, May 26 2017

Labels: Proj-MaterialDesign-CrOS
Project Member

Comment 4 by bugdroid1@chromium.org, May 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d71bc7b31de04a31db7c360da95c5d1ff53b6784

commit d71bc7b31de04a31db7c360da95c5d1ff53b6784
Author: Evan Stade <estade@chromium.org>
Date: Sat May 27 19:16:20 2017

Rename GetPreferredSize overrides to CalculatePreferredSize and make
View::GetPreferredSize non-virtual.

I wanted to do this in a more piecemeal fashion, but realized that would
be problematic because if a subclass calls through to its parent's
CalculatePreferredSize, it might not do anything if the parent is still
overriding GetPreferredSize only. On the other hand, if a subclass
calls GetPreferredSize it could land in an infinite loop since
view::GetPreferredSize calls CalculatePreferredSize.

Bug:  724447 
Change-Id: I46c02710ac4319c22acbcefd993a0376dc9df97a
Reviewed-on: https://chromium-review.googlesource.com/516542
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475249}
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/apps/ui/views/app_window_frame_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/apps/ui/views/app_window_frame_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ash/shelf/shelf_tooltip_manager.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ash/system/tray/hover_highlight_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ash/system/tray/tray_item_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/chromeos/attestation/platform_verification_dialog.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/chromeos/attestation/platform_verification_dialog.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/chromeos/enrollment_dialog_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/chromeos/options/network_config_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/chromeos/options/network_config_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/chromeos/options/wifi_config_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/chromeos/ui/echo_dialog_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/chromeos/ui/echo_dialog_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/chromeos/ui/kiosk_external_update_notification.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/ash/multi_user/multi_user_warning_dialog.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/cocoa/bubble_anchor_helper_views_unittest.mm
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/apps/glass_app_window_frame_view_win.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/apps/glass_app_window_frame_view_win.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/autofill/card_unmask_prompt_views.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/bookmarks/bookmark_editor_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/chrome_cleaner_dialog_win.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/chrome_cleaner_dialog_win.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/collected_cookies_views.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/content_setting_bubble_contents.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/content_setting_bubble_contents.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/create_application_shortcut_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/create_application_shortcut_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/device_chooser_content_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/device_chooser_content_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/download/download_item_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/download/download_item_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/download/download_shelf_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/download/download_shelf_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/extensions/extension_install_dialog_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/extensions/extension_popup.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/extensions/extension_popup.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/extensions/request_file_system_dialog_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/find_bar_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/frame/windows_10_caption_button.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/frame/windows_10_caption_button.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/ime/ime_window_frame_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/ime/ime_window_frame_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/importer/import_lock_dialog_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/importer/import_lock_dialog_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/infobars/infobar_container_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/infobars/infobar_container_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/infobars/infobar_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/location_bar/bubble_icon_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/location_bar/keyword_hint_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/location_bar/keyword_hint_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/location_bar/selected_keyword_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/location_bar/selected_keyword_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/omnibox/omnibox_result_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/page_info/page_info_bubble_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/passwords/account_chooser_dialog_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/passwords/credentials_item_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/passwords/credentials_item_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/payments/payment_request_dialog_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/profiles/avatar_button.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/profiles/avatar_button.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/profiles/user_manager_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/profiles/user_manager_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/screen_capture_notification_ui_views.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/settings_reset_prompt_dialog.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/settings_reset_prompt_dialog.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/status_bubble_views.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/status_bubble_views.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/tab_icon_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/tab_icon_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/task_manager_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/task_manager_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/toolbar/app_menu.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/toolbar/app_menu_button.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/toolbar/app_menu_button.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/toolbar/browser_actions_container.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/toolbar/toolbar_action_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/toolbar/toolbar_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/translate/translate_bubble_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/translate/translate_bubble_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/chrome/browser/ui/views/webshare/webshare_target_picker_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/components/exo/shell_surface.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/components/exo/shell_surface.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/mash/example/window_type_launcher/window_type_launcher.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/mash/quick_launch/quick_launch.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/mash/simple_wm/simple_wm.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/app_list_folder_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/app_list_folder_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/apps_container_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/apps_container_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/apps_grid_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/contents_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/contents_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/folder_header_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/folder_header_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/page_switcher.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/page_switcher.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/search_box_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/search_result_list_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/search_result_list_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/search_result_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/search_result_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/speech_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/speech_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/tile_item_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/tile_item_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/top_icon_animation_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/app_list/views/top_icon_animation_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/arc/notification/arc_notification_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/arc/notification/arc_notification_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/chromeos/ime/candidate_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/chromeos/ime/candidate_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/chromeos/ime/candidate_window_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/chromeos/ime/infolist_window.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/chromeos/ime/mode_indicator_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/chromeos/ime/mode_indicator_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/bounded_label.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/bounded_label.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/message_center_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/message_center_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/message_center_view_unittest.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/message_list_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/message_list_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/message_list_view_unittest.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/notification_button.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/notification_button.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/notification_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/notification_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/notifier_settings_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/notifier_settings_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/toast_contents_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/message_center/views/toast_contents_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/bubble/bubble_dialog_delegate_unittest.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/bubble/bubble_frame_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/bubble/bubble_frame_view_unittest.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/bubble/info_bubble.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/bubble/info_bubble.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/bubble/tray_bubble_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/bubble/tray_bubble_view.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/color_chooser/color_chooser_view.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/controls/button/checkbox.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/controls/button/label_button.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/controls/button/menu_button.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/controls/button/menu_button.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/controls/button/toggle_button.cc
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/controls/button/toggle_button.h
[modify] https://crrev.com/d71bc7b31de04a31db7c360da95c5d1ff53b6784/ui/views/controls/combobox/combobox.cc
[modify] https://crrev.com/d71bc

Comment 5 by est...@chromium.org, May 30 2017

Labels: Merge-Request-60
this looks like a big change, but it's mostly 1 line changes in each file and it landed just after the branch. It fixes this bug and probably some other as-yet-undiscovered bugs. Hence, requesting a merge.
Project Member

Comment 6 by sheriffbot@chromium.org, May 30 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by est...@chromium.org, May 30 2017

Status: Fixed (was: Started)
https://chromium-review.googlesource.com/c/517991/

Comment 8 by est...@chromium.org, May 30 2017

Labels: Merge-Merged

Comment 9 by est...@chromium.org, Jun 2 2017

Cc: est...@chromium.org sgabr...@chromium.org
 Issue 729076  has been merged into this issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 5 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by est...@chromium.org, Jun 5 2017

Labels: -Merge-Approved-60

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment