New issue
Advanced search Search tips

Issue 724442 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Delete two unused ContentBrowserClient methods that seemingly access cookie settings

Project Member Reported by engedy@chromium.org, May 19 2017

Issue description

To the casual reader, two methods on ContentBrowserClient would imply that the corresponding features are gated on cookie settings. In fact, however, the corresponding features no longer exist.

-- ContentBrowserClient::AllowSaveLocalState

This was used for NPAPI plugins (primarily: Flash) to turn on in-memory storage for Local Shared Objects if cookie content settings were set to session only. The call site was deleted as part of NPAPI removal in [1], but this method was not. Furthermore, PPAPI Flash now uses a different code path to retrieve cookie settings (see: PepperFlashBrowserHost::GetLocalDataRestrictions).

-- ContentBrowserClient::AllowWebRTCIdentityCache

This was used to disable the Chromium implementation of WebRTC's DtlsIdentityStoreInterface, which provided caching of identities/certificates to be used for the DTLS handshake by a peer connection. This identity is no longer generated or cached by Chromium (see [1] and [2]), instead it is now generated every time by WebRTC.

[1]: https://crrev.com/385358
[2]: https://codereview.chromium.org/2033353002/
[3]: https://codereview.chromium.org/2137023002
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee2eb64012f4a4ff273696a929450816a14a7da2

commit ee2eb64012f4a4ff273696a929450816a14a7da2
Author: engedy <engedy@chromium.org>
Date: Mon May 22 19:30:13 2017

Clean up unused ContentBrowserClient methods that access cookie settings.

This CL deletes the following two methods in ContentBrowserClient that were
used to retrieve cookie settings on behalf of features that no longer exist:

ContentBrowserClient::AllowSaveLocalState
ContentBrowserClient::AllowWebRTCIdentityCache

See the bug for details.

BUG= 724442 , webrtc:5708 , 493212 

Review-Url: https://codereview.chromium.org/2888373003
Cr-Commit-Position: refs/heads/master@{#473656}

[modify] https://crrev.com/ee2eb64012f4a4ff273696a929450816a14a7da2/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/ee2eb64012f4a4ff273696a929450816a14a7da2/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/ee2eb64012f4a4ff273696a929450816a14a7da2/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/ee2eb64012f4a4ff273696a929450816a14a7da2/content/public/browser/content_browser_client.h

Comment 2 by engedy@chromium.org, May 22 2017

Status: Fixed (was: Started)

Sign in to add a comment