New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724441 link

Starred by 3 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: May 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ sureshkumari@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Extra spacing seen between File icon and search engine extension description

Project Member Reported by divya.pa...@techmahindra.com, May 19 2017 
Chrome Version:60.0.3104.0
OS: Ubuntu 14.04, Win: 7

What steps will reproduce the problem?
1. Launch chrome and Add any search engine extension(eg:SSH shortcut) from webstore.
2. Navigate to chrome://md-settings/searchEngines
3. Observe the content under search engines added by extensions section

Expected 
Content should be proper under search engines added by extensions section.

Actual
Misalignment of Content is seen under search engines added by extensions section


This is a Regression issue seen in M-60

Manual Biscet Info
================
Good build:60.0.3083.0
Bad build: 60.0.3084.0
Actual.Search Engine.ogv
1023 KB View Download
Expected Search Engine.ogv
1.4 MB View Download

Comment 1 by divya.pa...@techmahindra.com, May 19 2017

Search engine screenshot
29.1 KB View Download

Comment 2 by kavvaru@chromium.org, May 19 2017

Components: -UI UI>Settings
Labels: -Type-Bug -Pri-3 Proj-MaterialDesign-WebUI Needs-Bisect M-60 OS-Mac Pri-1 Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.12.4 using chrome version 60.0.3104.0

Comment 3 by sureshkumari@chromium.org, May 19 2017

Cc: sureshkumari@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build:60.0.3083.0 -(Revision:467821).
Bad build: 60.0.3084.0 -(Revision:468182).
CHANGE-LOG URL:
https://chromium.googlesource.com/chromium/src/+log/ae182230f56e92bc952ba62c8d6800e56f206008..52cb55108113396c95ba08d9e40c0ba18f528de3

Review-Url: https://codereview.chromium.org/2839413004
dpapad@ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks..

Comment 4 by dpa...@chromium.org, May 22 2017

Labels: -Pri-1 Pri-2
Status: Started (was: Assigned)

Comment 5 by dbeam@chromium.org, May 22 2017

Labels: Hotlist-MD-Settings-SearchEngines
Project Member

Comment 6 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2931c53f2d672256b89ebcf133119e3608b9fef

commit c2931c53f2d672256b89ebcf133119e3608b9fef
Author: dpapad <dpapad@chromium.org>
Date: Tue May 23 00:19:35 2017

MD Settings: Fix omnibox search engine name misalignment.

BUG= 724441 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2898023002
Cr-Commit-Position: refs/heads/master@{#473759}

[modify] https://crrev.com/c2931c53f2d672256b89ebcf133119e3608b9fef/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/c2931c53f2d672256b89ebcf133119e3608b9fef/chrome/browser/resources/settings/search_engines_page/search_engine_entry_css.html

Comment 7 by dpa...@chromium.org, May 23 2017

Status: Fixed (was: Started)

Comment 8 by kkaluri@chromium.org, May 30 2017

Labels: TE-Verified-M60 TE-Verified-60.0.3112.7
Tested this issue on Windows 10, Ubuntu 14.04 and Mac 10.12.4 with chrome #60.0.3112.7
Observed fix is working as expected.

Adding screen-cast for reference.
Issue 724441.mp4
464 KB View Download
►

Sign in to add a comment