Add action when the user tap or long press the most visited tiles.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0 commit d9ba02556dbc40c2059778aaab0f3e1dabc1acd0 Author: gambard <gambard@chromium.org> Date: Tue Jun 06 12:01:38 2017 Open Most Visited items Open the Most Visited items when tapped and log the action. BUG= 724427 Review-Url: https://codereview.chromium.org/2890193003 Cr-Commit-Position: refs/heads/master@{#477262} [modify] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/chrome/browser/content_suggestions/mediator_util.mm [modify] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn [modify] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.h [modify] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm [modify] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item_unittest.mm [modify] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h [modify] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [add] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/chrome/browser/ui/favicon/OWNERS [modify] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/chrome/browser/ui/favicon/favicon_attributes.h [modify] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/chrome/browser/ui/favicon/favicon_attributes.mm [modify] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/chrome/browser/ui/favicon/favicon_attributes_provider.mm [modify] https://crrev.com/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0/ios/showcase/content_suggestions/sc_content_suggestions_data_source.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e810041bc721983ffc3331c1a4ec69726fbfc0d0 commit e810041bc721983ffc3331c1a4ec69726fbfc0d0 Author: gambard <gambard@chromium.org> Date: Tue Jun 06 13:20:13 2017 Add long press actions for Most Visited tiles Add the long press actions for the Most Visited tiles: - Open in New Tab - Open in New Incognito Tab - Delete BUG= 724427 Review-Url: https://codereview.chromium.org/2891363002 Cr-Commit-Position: refs/heads/master@{#477270} [modify] https://crrev.com/e810041bc721983ffc3331c1a4ec69726fbfc0d0/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/e810041bc721983ffc3331c1a4ec69726fbfc0d0/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/e810041bc721983ffc3331c1a4ec69726fbfc0d0/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/e810041bc721983ffc3331c1a4ec69726fbfc0d0/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h [modify] https://crrev.com/e810041bc721983ffc3331c1a4ec69726fbfc0d0/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/e810041bc721983ffc3331c1a4ec69726fbfc0d0/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h [modify] https://crrev.com/e810041bc721983ffc3331c1a4ec69726fbfc0d0/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28050dfc93a9ff9de70fcfba4e49aefdfc08d5fc commit 28050dfc93a9ff9de70fcfba4e49aefdfc08d5fc Author: gambard <gambard@chromium.org> Date: Wed Jun 07 11:05:37 2017 Reload the Most Visited section when it changes When the Most Visited model changes, the UI should be updated only on user interaction. BUG= 707754 , 724427 Review-Url: https://codereview.chromium.org/2923973002 Cr-Commit-Position: refs/heads/master@{#477610} [modify] https://crrev.com/28050dfc93a9ff9de70fcfba4e49aefdfc08d5fc/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/28050dfc93a9ff9de70fcfba4e49aefdfc08d5fc/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
Verified on iPad iOS 10.3.2,iPhone iOS 10.3.1 on 61.0.3128.0 canary "Handle Most Visited tiles actions" looks good
This bug is related to Content Suggestions on NTP, so not yet ready for testing. Ignore the verification in comment#5. Changing the status back to fixed, so that this will be verified in future.
Comment 1 by bugdroid1@chromium.org
, Jun 6 2017