Issue metadata
Sign in to add a comment
|
Regression: Unable to modify settings in 'Manage other users' page on every first login as owner. |
||||||||||||||||||||||
Issue descriptionChrome Version:60.0.3102.0/9565.0.0 dev channel Kip,Paine,Blaze OS: Chrome OS What steps will reproduce the problem? (1)Recover build via USB >> Sign in to chrome as Owner (2)Go to chrome://md-settings/accounts page and Observe Expected: For owner, all options in manage other users should be editable. Actual: Instead,unable to modify the settings(All options are seen disable with tool-tip as 'This settings are managed by owner' even on logging in as owner) (Please refer video) Note: This issue is seen only when logged in for the first time as owner.Once we sign out and sign-in everything looks fine. This is regression issue as no such behavior is seen in 59.0.3071.57/9460.43.0 beta channel Kip. Attaching screen-cast for reference.
,
May 19 2017
Not really a regression. ProfileHelper::IsOwnerProfile() is fine. But owner status is static. It is only static after owner key is verified on chrome start. The first time signing in when user takes ownership, we also need an extra 1+ seconds to generate the key so it would take a bit longer. After owner key is verified, ProfileHelper::IsOwnerProfile() might change its return failure. Another possible repro is to open settings page, then kill chrome to force it restart. And owner section probably would be disabled on restart too. The reliable way to determine owner status is using OwnerSettingsService::IsOwnerAsync. The callback will be called when owner status is determined. Is it possible to do that?
,
May 19 2017
Correction to #2: I mean owner status is NOT static. :p
,
May 19 2017
Yep, the extension API is already async, I will make that change, thanks!
,
May 22 2017
,
May 25 2017
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08449a9d4ce38aeb0c5e0519e1f09fc1de1a42a0 commit 08449a9d4ce38aeb0c5e0519e1f09fc1de1a42a0 Author: stevenjb <stevenjb@chromium.org> Date: Tue May 30 17:42:48 2017 Settings: Users: Make isCurrentUserOwner async BUG= 724421 Review-Url: https://codereview.chromium.org/2902253004 Cr-Commit-Position: refs/heads/master@{#475584} [modify] https://crrev.com/08449a9d4ce38aeb0c5e0519e1f09fc1de1a42a0/chrome/browser/chromeos/extensions/users_private/users_private_api.cc [modify] https://crrev.com/08449a9d4ce38aeb0c5e0519e1f09fc1de1a42a0/chrome/browser/chromeos/extensions/users_private/users_private_api.h [modify] https://crrev.com/08449a9d4ce38aeb0c5e0519e1f09fc1de1a42a0/chrome/browser/chromeos/extensions/users_private/users_private_apitest.cc
,
May 30 2017
This is enough of an edge case that I don't think we need to merge this back to 60 or 59.
,
Jun 16 2017
Chrome OS 9656.0.0, 61.0.3132.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, May 19 2017