New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724414 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 726213
issue 726229
issue 728892

Blocking:
issue 719266



Sign in to add a comment

ext4 crypto migration: Figure out why we have "file not found" error and fix it

Project Member Reported by uekawa@google.com, May 19 2017

Issue description

So far what we know about this:
 - Suspected to be happening in open() and getxattr() to about 1% of users in M60 dev channel
 - not in a particular file.

 

Comment 1 by uekawa@google.com, May 19 2017

Labels: ArcExt4Migration OS-Chrome
Summary: ext4 crypto migration: Figure out why we have "file not found" error and fix it (was: Figure out why we have "file not found" error and fix it)

Comment 2 by uekawa@google.com, May 19 2017

Cc: hashimoto@chromium.org

Comment 3 by dspaid@chromium.org, May 22 2017

We know of one expected case for this, where the machine shuts down during migration (homedir is unmounted in the middle of migration, causing the files to disappear)

The only other reason I can think of that files would disappear is due to low storage cleanup, but that should happen on the same thread as the migration, so it shouldn't be an issue.

Comment 4 by uekawa@chromium.org, May 23 2017

why does the unmount happen in middle of migration ? Does it happen on a different cryptohome thread?

Comment 5 by dspaid@chromium.org, May 23 2017

Yes, Unmount is called on the main thread, whereas the migration is run on the mount thread.  Unmount should probably be called on the mount thread as well.

Comment 6 by uekawa@chromium.org, May 25 2017

summary of current understanding 

 - power shutdown is currently allowed and that causes an error to be sent out, we should disallow that b/35900434
 - power shutdown and retry probably results in resumed successful migration (to be confirmed by dan)
 - cryptohome should do something about error stats or gracefully handle normal shutdown if it really gracefully handles normal shutdown.




Comment 7 by dspaid@chromium.org, May 25 2017

Ok, the culprit seems to be the powerd policy.  In login screen lid close policy is to shutdown, and we never change that since we stop the signin flow early.  This should be changed to suspend.  Tracked at
https://bugs.chromium.org/p/chromium/issues/detail?id=726229

As for successful migrations:
I'm analyzing the stats, but there's definitely discrepancies.  In particular we've got a lot of client IDs for which we seem to have partial stats (more end statuses than start statuses, more successes than initial migration attempts, etc).  However the vast majority of these failures do seem to eventually lead to successful migrations, and the outstanding ones could easily be explained by people that shut the lid and just haven't gotten around to logging back in yet.

Comment 8 by uekawa@google.com, Jun 2 2017

Blockedon: 726229 726213 728892
There's a report from tester that might be different case than what we know
https://bugs.chromium.org/p/chromium/issues/detail?id=728892

Comment 9 by uekawa@google.com, Jun 20 2017

Status: Fixed (was: Assigned)
sub-bugs are closed, mark this as fixed?

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment