New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724394 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Misalignment of button is seen on ‘Do not Track’ overlay.

Reported by abom...@etouch.net, May 19 2017 
Chrome Version:60.0.3104.0 (Official Build) (cohort: Stable)a64d3f2e11c37e5c017c4ae5cceb10b8144eaf0f-refs/heads/master@{#473014}(32/64-bit).
OS:Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://settings/privacy
2. Click on toggle button of ‘Send a “Do not track” request with your browsing traffic such that overlay is seen.
3. Observe button.

Actual:Misalignment of button is seen.
Expected: Misalignment should not be seen.

This is regression issue, broken in ‘M 60’ and will soon provide other info.

Comment 1 by abom...@etouch.net, May 19 2017 

Manual bisect:
Good build:60.0.3102.0(472263)
Bad build:60.0.3103.0(472587)
Actual:exp.png
125 KB View Download

Comment 2 by abom...@etouch.net, May 19 2017

Labels: hasbisect
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/ad2fac2570c69d70b459d284aa469feab9928dbe..a6fc2f20dd92dbf5ea9b73ae877708efd0f432d4?pretty=fuller&n=100

Suspecting: r472301

Comment 3 by dschuyler@chromium.org, May 19 2017

Status: Started (was: Assigned)
CL at https://codereview.chromium.org/2899533002/
Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/516d1b3d84dece163efa12412b76f10a0f4ba5b1

commit 516d1b3d84dece163efa12412b76f10a0f4ba5b1
Author: dschuyler <dschuyler@chromium.org>
Date: Wed May 24 23:54:53 2017

[MD settings] move <dialog> out of content

This CL moves the "Do not track" dialog out of the page content where it
was picking up css erroneously.

BUG= 724394 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2899533002
Cr-Commit-Position: refs/heads/master@{#474481}

[modify] https://crrev.com/516d1b3d84dece163efa12412b76f10a0f4ba5b1/chrome/browser/resources/settings/controls/settings_toggle_button.js
[modify] https://crrev.com/516d1b3d84dece163efa12412b76f10a0f4ba5b1/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/516d1b3d84dece163efa12412b76f10a0f4ba5b1/chrome/browser/resources/settings/privacy_page/privacy_page.js

Comment 5 by dschuyler@chromium.org, May 24 2017

Status: Fixed (was: Started)

Comment 6 by sureshkumari@chromium.org, May 30 2017

Labels: TE-Verified-60.0.3112.7 TE-Verified-M60
Tested the issue on Mac-10.12.4,Ubuntu-14.04 & windows-7 using chrome dev version#60.0.3112.7 with the steps mentioned in comment #0.Observed that the fix is working as expected. Hence adding TE-Verified labels.

Please find the attached screen cast for the same.
Thanks!!
724394.mp4
505 KB View Download
►

Sign in to add a comment