New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724392 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 717347



Sign in to add a comment

fast/css/font-family-case-insensitive.html is flaky on Windows (when run on swarming)

Project Member Reported by r...@igalia.com, May 19 2017

Issue description


The following layout test is flaky on Windows random order bot:
* fast/css/font-family-case-insensitive.html

You can check for example the following build:
https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Win%20-%20RandomOrder/builds/3341

And the actual:
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=fa9d5675ebbf7fab0f00ac3761775824d5e4234c&as=layout-test-results%5Cfast%5Ccss%5Cfont-family-case-insensitive-actual.png
vs expected results:
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=fbb40d3556b05f7e9f55d945c21c92aec8999e05&as=layout-test-results%5Cfast%5Ccss%5Cfont-family-case-insensitive-expected.png

It seems Windows is somehow slow when loading "ahem" font (note that it's lowercase).
If you use "Ahem" instead, the issue is gone.
More info about this on  bug #719299 .

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5c323b49440e551e321155f7a9bdb80fec5f80a

commit a5c323b49440e551e321155f7a9bdb80fec5f80a
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Fri May 19 08:37:31 2017

LayoutTests: Disable flaky test on Windows

The following test is flacky on Windows Random Order bots:
* fast/css/font-family-case-insensitive.html

The issue is that it uses "ahem" instead of "Ahem" as font,
and for some reason that's causing the flakiness.

This patch flags it on TestExpectations.

BUG= 717347 , 724392 
TBR=qyearsley@chromium.org,tansell@chromium.org

Change-Id: I7676bfcf4ab9f6759b7a705c159621a8bfc5e496
Reviewed-on: https://chromium-review.googlesource.com/509448
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#473129}
[modify] https://crrev.com/a5c323b49440e551e321155f7a9bdb80fec5f80a/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by e...@chromium.org, May 25 2017

Status: Available (was: Untriaged)

Comment 3 by suzyh@chromium.org, Jun 13 2017

Cc: -suzyh@chromium.org meade@chromium.org

Comment 4 by r...@igalia.com, Feb 28 2018

Cc: kojii@chromium.org foolip@chromium.org wangxianzhu@chromium.org r...@igalia.com
 Issue 817030  has been merged into this issue.

Comment 5 by r...@igalia.com, Feb 28 2018

As we import more tests from web-platform-tests, we're hitting this problem over and over.

Last example is  issue #817030  (related to css-text test suite importation).
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df22bb027548a30b947e0bce39b3b829ad2aa37e

commit df22bb027548a30b947e0bce39b3b829ad2aa37e
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Wed Feb 28 10:34:01 2018

[css-multicol] Use "Ahem" instead of "ahem" in tests

"ahem" is causing flakiness on Windows, so this patch
just replaces "ahem" by "Ahem" on WPT tests.

BUG= 724392 , 794136 

Change-Id: I55ce2ee7ed36b2708da571f52256716e97a072cb
Reviewed-on: https://chromium-review.googlesource.com/940921
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#539780}
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-002-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-002.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-balance-001-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-balance-001.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-003.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-3-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-002.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-fraction-003.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-fraction-3-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-px-001.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-shorthand-2-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-shorthand-2.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-stacking-001.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-stacking-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-shorthand-001.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-block-sibling-003.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-block-sibling-3-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-margin-nested-firstchild-001.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-margin-nested-firstchild-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-table-cell-vertical-align-001.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-table-cell-vertical-align-ref.xht

Comment 7 by r...@igalia.com, Feb 28 2018

Cc: robertma@chromium.org mstensho@chromium.org qyears...@chromium.org
 Issue 794136  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e30720e61f0306dc4efa540ba89e99889cc4677

commit 7e30720e61f0306dc4efa540ba89e99889cc4677
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Wed Feb 28 12:22:33 2018

[css-ui] Use "Ahem" instead of "ahem" in tests

"ahem" is causing flakiness on Windows, so this patch
just replaces "ahem" by "Ahem" on css-ui WPT tests.

BUG= 724392 , 796733 

Change-Id: I956e939790319ec956164f34af8c72f109c528ef
Reviewed-on: https://chromium-review.googlesource.com/940133
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#539797}
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/outline-016.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/reference/text-overflow-008-ref.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/reference/text-overflow-013-ref.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-007.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-008.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-010.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-011.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-013.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-014.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-015.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-016.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-017.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-020.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-023.html

Comment 9 by r...@igalia.com, Feb 28 2018

 Issue 796733  has been merged into this issue.

Comment 10 by meade@google.com, Feb 28 2018

Cc: -meade@chromium.org e...@chromium.org
Status: Fixed (was: Available)
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cb4beb90a52e868973367fc505b0994de23819b

commit 3cb4beb90a52e868973367fc505b0994de23819b
Author: Robert Ma <robertma@chromium.org>
Date: Thu Sep 27 22:00:59 2018

Unskip fast/css/font-family-case-insensitive.html

The flaky lower-case font matching ("ahem") has been fixed in
https://crrev.com/c/1249385 , so we can unskip this test now.

Bug:  724392 
Change-Id: I2a005fe055684aa9e8662a0324a6f7ad84935a1a
Reviewed-on: https://chromium-review.googlesource.com/1249276
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594886}
[modify] https://crrev.com/3cb4beb90a52e868973367fc505b0994de23819b/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment