New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724383 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Aug 27
Cc:
pdr@chromium.org
wangxianzhu@chromium.org
█ wkorman@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Move DocumentMarkerController::InvalidateRectsForAllMarkers() in Document::LayoutUpdated() to paint invalidation phase

Project Member Reported by yosin@chromium.org, May 19 2017 
Document::LayoutUpdated(), which called at end of FrameView::UpdateLayout(),
calls DMC::InvalidateRectsForAllMarkers() to invalidate tick marks, text match
of find-in-page, in scrollbar. 

In other words, we update tick mark rects at kLayoutClean phase.

However, we don't need to do so, since we may have another layout tree update.

Thus, we should move DMC::InvalidateRectsForAllMarkers() call into kInPaintInvalidation phase.

wkorman@, WDYT?

Comment 1 by yosin@chromium.org, May 19 2017

Labels: -Performance Performance-Responsiveness

Comment 2 by wkorman@chromium.org, Aug 25 2017

Cc: pdr@chromium.org wangxianzhu@chromium.org wkorman@chromium.org
Owner: ----
Status: Available (was: Assigned)
This work item could have changed with SPInvalidation. I am not actively working on it. Adding folks with paint invalidation expertise and unassigning self.
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 27

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by wangxianzhu@chromium.org, Aug 27

Status: Fixed (was: Untriaged)
I think we have already done this. Now DMC only marks the parts needing invalidation during layout.
►

Sign in to add a comment