New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724381 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 23
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Tab Switching Benchmark for ChromeOS

Project Member Reported by vovoy@chromium.org, May 19 2017

Issue description

The generic tab switching benchmark (see https://bugs.chromium.org/p/chromium/issues/detail?id=689388) cannot handle the case that some tabs are discards and lose context.

Rewrite tab switching benchmark using some cros only features.

The following code would not work if tab can be discarded.

for tab in action_runner.tab.browser.tabs:
  tab.Activate()
  tab.WaitForFrameToBeDisplayed()

using send key event to switch tabs instead.

Usage to open 120 tabs:
chromium/src/tools/perf/run_benchmark --browser=cros-chrome --remote=DUT_IP cros_tab_switching.typical_24 --tabset-repeat=5
 

Comment 1 by vovoy@chromium.org, May 19 2017

Cc: bccheng@chromium.org deanliao@chromium.org
Great. Probably name it as tab_switching_cros.* ? 

Comment 3 by vovoy@chromium.org, May 19 2017

current name to launch the benchmark is cros_tab_switching.typical_24, change to tab_switching_cros.typical_24?

ex:
$ ./run_benchmark --browser=cros-chrome --remote=DUT_IP cros_tab_switching.typical_24 --tabset-repeat=5

Comment 4 by vovoy@chromium.org, May 19 2017

Description: Show this description

Comment 5 by vovoy@chromium.org, May 23 2017

Description: Show this description

Comment 6 by vovoy@chromium.org, May 23 2017

Description: Show this description
Project Member

Comment 7 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e

commit 2675d3c72d3ad2257e6efb8775b1c54266ccfb7e
Author: vovoy <vovoy@chromium.org>
Date: Fri May 26 09:25:40 2017

Tab Switching Benchmark for ChromeOS

Copy the tab switching benchmark to cros_benchmarks. Using key events for
simulate tab switching behavior to handle the case that some tab contexts
may be discarded.

Example usage to open 120 tabs:
$ ./run_benchmark --browser=cros-chrome --remote=DUT_IP
cros_tab_switching.typical_24 --tabset-repeat=5

BUG= 724381 

Review-Url: https://codereview.chromium.org/2890333002
Cr-Commit-Position: refs/heads/master@{#474975}

[add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/.gitignore
[add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/cros_utils.py
[add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/data/log_key_tab_switch
[add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/data/tab_switching.json
[add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/data/tab_switching.wpr.sha1
[add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/tab_switching_bench.py
[add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/tab_switching_measure.py
[add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/tab_switching_stories.py

Comment 8 by vovoy@chromium.org, Jun 14 2017

Description: Show this description

Comment 9 by vovoy@chromium.org, Jun 22 2017

Cc: semenzato@chromium.org slavamn@chromium.org vovoy@chromium.org sonnyrao@chromium.org
 Issue 309683  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26e771d2dd407e77f8b618d98ef66eb09fcb86fa

commit 26e771d2dd407e77f8b618d98ef66eb09fcb86fa
Author: Vovo Yang <vovoy@google.com>
Date: Wed Oct 18 15:07:28 2017

Add option --pause-after-creation

Add option to specify the pause between tab creation and tab switch
so that tester can manually do something during this pause.

Bug:  724381 
Change-Id: I3440edab585c64aef4c74b64a86162d75e3f6173
Reviewed-on: https://chromium-review.googlesource.com/721105
Commit-Queue: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Cheng-Yu Lee <cylee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509771}
[modify] https://crrev.com/26e771d2dd407e77f8b618d98ef66eb09fcb86fa/tools/perf/contrib/cros_benchmarks/tab_switching_bench.py
[modify] https://crrev.com/26e771d2dd407e77f8b618d98ef66eb09fcb86fa/tools/perf/contrib/cros_benchmarks/tab_switching_stories.py

Status: Fixed (was: Started)

Sign in to add a comment