Tab Switching Benchmark for ChromeOS |
|||||||
Issue descriptionThe generic tab switching benchmark (see https://bugs.chromium.org/p/chromium/issues/detail?id=689388) cannot handle the case that some tabs are discards and lose context. Rewrite tab switching benchmark using some cros only features. The following code would not work if tab can be discarded. for tab in action_runner.tab.browser.tabs: tab.Activate() tab.WaitForFrameToBeDisplayed() using send key event to switch tabs instead. Usage to open 120 tabs: chromium/src/tools/perf/run_benchmark --browser=cros-chrome --remote=DUT_IP cros_tab_switching.typical_24 --tabset-repeat=5
,
May 19 2017
Great. Probably name it as tab_switching_cros.* ?
,
May 19 2017
current name to launch the benchmark is cros_tab_switching.typical_24, change to tab_switching_cros.typical_24? ex: $ ./run_benchmark --browser=cros-chrome --remote=DUT_IP cros_tab_switching.typical_24 --tabset-repeat=5
,
May 19 2017
,
May 23 2017
,
May 23 2017
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e commit 2675d3c72d3ad2257e6efb8775b1c54266ccfb7e Author: vovoy <vovoy@chromium.org> Date: Fri May 26 09:25:40 2017 Tab Switching Benchmark for ChromeOS Copy the tab switching benchmark to cros_benchmarks. Using key events for simulate tab switching behavior to handle the case that some tab contexts may be discarded. Example usage to open 120 tabs: $ ./run_benchmark --browser=cros-chrome --remote=DUT_IP cros_tab_switching.typical_24 --tabset-repeat=5 BUG= 724381 Review-Url: https://codereview.chromium.org/2890333002 Cr-Commit-Position: refs/heads/master@{#474975} [add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/.gitignore [add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/cros_utils.py [add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/data/log_key_tab_switch [add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/data/tab_switching.json [add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/data/tab_switching.wpr.sha1 [add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/tab_switching_bench.py [add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/tab_switching_measure.py [add] https://crrev.com/2675d3c72d3ad2257e6efb8775b1c54266ccfb7e/tools/perf/contrib/cros_benchmarks/tab_switching_stories.py
,
Jun 14 2017
,
Jun 22 2017
Issue 309683 has been merged into this issue.
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63ece55570c7a7b45e41bb6b07192d5f021b76fa commit 63ece55570c7a7b45e41bb6b07192d5f021b76fa Author: Vovo Yang <vovoy@google.com> Date: Fri Sep 29 01:21:25 2017 [wpr-go] Switch tab_switching.json to use go Bug: 724381 Change-Id: I38ef54257142367075157c6436f9a773620535ac Reviewed-on: https://chromium-review.googlesource.com/690755 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#505241} [modify] https://crrev.com/63ece55570c7a7b45e41bb6b07192d5f021b76fa/tools/perf/contrib/cros_benchmarks/data/tab_switching.json [delete] https://crrev.com/8f504496ded8b34698c0883f895d73bafdbc1a70/tools/perf/contrib/cros_benchmarks/data/tab_switching.wpr.sha1 [add] https://crrev.com/63ece55570c7a7b45e41bb6b07192d5f021b76fa/tools/perf/contrib/cros_benchmarks/data/tab_switching.wprgo.sha1
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26e771d2dd407e77f8b618d98ef66eb09fcb86fa commit 26e771d2dd407e77f8b618d98ef66eb09fcb86fa Author: Vovo Yang <vovoy@google.com> Date: Wed Oct 18 15:07:28 2017 Add option --pause-after-creation Add option to specify the pause between tab creation and tab switch so that tester can manually do something during this pause. Bug: 724381 Change-Id: I3440edab585c64aef4c74b64a86162d75e3f6173 Reviewed-on: https://chromium-review.googlesource.com/721105 Commit-Queue: Vovo Yang <vovoy@chromium.org> Reviewed-by: Cheng-Yu Lee <cylee@chromium.org> Cr-Commit-Position: refs/heads/master@{#509771} [modify] https://crrev.com/26e771d2dd407e77f8b618d98ef66eb09fcb86fa/tools/perf/contrib/cros_benchmarks/tab_switching_bench.py [modify] https://crrev.com/26e771d2dd407e77f8b618d98ef66eb09fcb86fa/tools/perf/contrib/cros_benchmarks/tab_switching_stories.py
,
Aug 23
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by vovoy@chromium.org
, May 19 2017