New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724367 link

Starred by 26 users
Status: Fixed
Owner:
danakj@chromium.org
Closed: May 2017
Cc:
danakj@chromium.org
pdr@chromium.org
█ manzagop@chromium.org
ajha@chromium.org
gov...@chromium.org
█ manoranj...@chromium.org
█ jainabhi...@chromium.org
█ kavvaru@chromium.org
bsep@chromium.org
nyerramilli@chromium.org
█ bustamante@chromium.org
jbroman@chromium.org
█ brajkumar@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
chrishtr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Weird behavior is seen in Wrench menu, Edit bookmark overlay on mouse hover.

Reported by avsha...@etouch.net, May 19 2017 
Chrome Version : 60.0.3104.0 (Official Build) a64d3f2e11c37e5c017c4ae5cceb10b8144eaf0f-refs/heads/master@{#473014} 32/64 bit
OS : Windows (7,8,10)

What steps will reproduce the problem?
1. Launch chrome, open Wrench menu and hover mouse on all the options in it.
2. Observe.

Actual : Weird behavior is seen in Wrench menu on mouse hover. (Please review an attachment)

Expected : Options in Wrench menu should not disappear on mouse hover. 

This is a regression issue broken in ‘M-60’, below is the Manual Regression range and will soon update other info.
Good build : 60.0.3103.0
Bad build : 60.0.3104.0

Note : Issue is seen on most of places in chrome like Tab names, Context menu, Edit Bookmark overlay etc.
Actual_Result.mp4
1.1 MB View Download

Comment 1 by avsha...@etouch.net, May 19 2017

Cc: bsep@chromium.org jbroman@chromium.org
Labels: hasbisect OS-Linux
Owner: danakj@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/ba5159d871bb21b4b151262dd9234d0261b81331..fb87ec0bcdec7fc2dc951380a9a8d27eb541ef65?pretty=fuller&n=10000

Suspecting : r 472917 or 472923? from Narrow Bisect 

@danakj : Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Note : Above issue is also seen on Linux (14.04 LTS) OS and same is working fine in Mac (10.11.6, 10.12.3).

Thank you!

Comment 2 by msrchandra@chromium.org, May 19 2017

Cc: danakj@chromium.org ajha@chromium.org chrishtr@chromium.org pdr@chromium.org kavvaru@chromium.org brajkumar@chromium.org
 Issue 724376  has been merged into this issue.

Comment 3 by msrchandra@chromium.org, May 19 2017

Labels: ReleaseBlock-Dev
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 4 by elawrence@chromium.org, May 19 2017 

Possibly also the same as  Issue 724474 ?

Comment 5 by siggi@chromium.org, May 19 2017

Cc: manzagop@chromium.org
 Issue 724474  has been merged into this issue.

Comment 6 by danakj@chromium.org, May 19 2017 

 Issue 724492  has been merged into this issue.

Comment 7 by danakj@chromium.org, May 19 2017 

I can reproduce UI elements flickering on linux tho its less obvious than on windows, for some reason. The bounds in DrawingDisplayItem was not being initialized in the copy constructor and doing so fixes the problem.

I don't get any MSan output with an is_asan=true build so I'm not 100% that it's the same issue, but the stack trace says that it would be.

Comment 8 by danakj@chromium.org, May 19 2017

Status: Fixed (was: Assigned)
The revert fixed this. I'm going to reland with the fix for this issue as well.

Comment 9 by pucchakayala@chromium.org, May 19 2017 

Issue 724578 has been merged into this issue.

Comment 10 by ajha@chromium.org, May 22 2017 

 Issue 724811  has been merged into this issue.

Comment 11 by jmukthavaram@chromium.org, May 22 2017 

 Issue 724576  has been merged into this issue.

Comment 12 by jmukthavaram@chromium.org, May 22 2017 

 Issue 724583  has been merged into this issue.

Comment 13 by kavvaru@chromium.org, May 22 2017 

 Issue 724749  has been merged into this issue.

Comment 14 by sureshkumari@chromium.org, May 22 2017 

 Issue 724831  has been merged into this issue.

Comment 16 by codegeek...@gmail.com, May 23 2017 

"This should be fixed on the latest Win-32 canary and Mac canary. Window 64 canary is not pushed to users since(60.0.3104.0) due to some build related issue."
What do x64 users do then?

Comment 17 by tobiasma...@gmail.com, May 23 2017 

Switch to a more stable channel?
Project Member

Comment 18 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29ef12086e6ac7eb83677e7730df00fda5c6af9b

commit 29ef12086e6ac7eb83677e7730df00fda5c6af9b
Author: danakj <danakj@chromium.org>
Date: Tue May 23 18:06:31 2017

Remove cullRect() from PaintOpBuffer.

Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
methods which is where it is used.

This allows us to more easily get rid of cc::DisplayItem and its
subclasses, replacing them with a PaintOpBuffer in DisplayItemList
directly instead. The difficulty I faced with that was that if
DisplayItemList has a single PaintOpBuffer, then it has a single
cull rect. However when painting, each "batch" of PaintOps can
have a different cull rect (corresponding to the PaintOps that
would have been in a single DisplayItem before). So, instead the
cull rect should be a property of recording at the
RecordPaintCanvas level, which is a temporary object. As such,
creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
need to manage the cull rect themselves to pass to things that
want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
this time).

Original code review was done on gerrit:
https://chromium-review.googlesource.com/c/503472

R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
BUG= 671433 ,  646010 ,  724367 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2889653002 .
Cr-Original-Commit-Position: refs/heads/master@{#472917}
Committed: https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359cbab45850b69
Review-Url: https://codereview.chromium.org/2889653002
Cr-Commit-Position: refs/heads/master@{#473975}

[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/blink/web_display_item_list_impl.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/blink/web_display_item_list_impl.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/layers/picture_image_layer.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/display_item_list.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/display_item_list_unittest.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/drawing_display_item.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/drawing_display_item.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_record.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_record.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_recorder.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_shader.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/record_paint_canvas.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/record_paint_canvas.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/test/fake_content_layer_client.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/test/solid_color_content_layer_client.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/trees/layer_tree_host_pixeltest_tiles.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/paint/BoxReflectionUtils.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/paint/ClipPathClipper.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/svg/graphics/SVGImage.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/BoxReflection.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/LoggingCanvas.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/Pattern.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/Pattern.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/PlaceholderImage.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[add] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItemTest.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/testing/TestPaintArtifact.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/web/LinkHighlightImpl.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/web/tests/scheduler/FrameThrottlingTest.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/public/platform/WebDisplayItemList.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/ui/compositor/paint_recorder.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/ui/compositor/paint_recorder.h

Comment 19 by jainabhi...@chromium.org, May 25 2017

Cc: bustamante@chromium.org gov...@chromium.org jainabhi...@chromium.org manoranj...@chromium.org
Issue 726181 has been merged into this issue.

Comment 20 by charliep...@gmail.com, May 25 2017 

Version 60.0.3108.0 (Official Build) canary (64-bit)
One build earlier (on my issues) These are SOLVED

Thanks Google people, for all the hard work

Comment 21 by sureshkumari@chromium.org, May 30 2017

Labels: TE-Verified-M60 TE-Verified-60.0.3112.7
Tested the issue on Ubuntu-14.04 & windows-7 using chrome dev version#60.0.3112.7 with the steps mentioned in comment #0.Observed that the fix is working as expected. Hence adding TE-Verified labels.

Please find the attached screen cast for the same.
Thanks!!
724367.mp4
1.2 MB View Download
►

Sign in to add a comment