New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724355 link

Starred by 1 user
Status: Fixed
Owner:
█ renjieliu@chromium.org
Last visit 29 days ago
Closed: Jul 2017
Cc:
goog...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Translate => revert => turn off network => translate erroneously shows an error message

Project Member Reported by napper@chromium.org, May 19 2017 
Chrome Version: 60.0.3103.3
OS: All

What steps will reproduce the problem?
(1) Navigate to a page that requires translation (e.g., yahoo.co.jp)
(2) Translate.
(3) Go back to the original.
(4) Turn of network.
(5) Translate.

What is the expected result?
Page is translate (cached version) and no error message.


What happens instead?
Page is translated, but an error message is displayed.
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d5f674e5ca5d6a9f0a2a9163bdba3615b2a83dd

commit 8d5f674e5ca5d6a9f0a2a9163bdba3615b2a83dd
Author: renjieliu <renjieliu@chromium.org>
Date: Mon May 22 23:30:22 2017

Remove offline check.

As it caused if there's cache, even translation succeeded it will still
reports failure. :(

We will revisit the fix after googleo@'s refactoring.

BUG= 724355 

Review-Url: https://codereview.chromium.org/2897573002
Cr-Commit-Position: refs/heads/master@{#473742}

[modify] https://crrev.com/8d5f674e5ca5d6a9f0a2a9163bdba3615b2a83dd/components/translate/content/browser/content_translate_driver.cc

Comment 2 by renjieliu@chromium.org, Jul 3 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment