New issue
Advanced search Search tips

Issue 724347 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 713524
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

nassh: hosts silently accepted with trailing whitespace

Project Member Reported by apollock@google.com, May 19 2017

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 9334.69.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.112 Safari/537.36
Platform: 9334.69.0 (Official Build) stable-channel zako

Steps to reproduce the problem:
1. Mistakenly enter a host with trailing whitespace
2. Use a relay host
3. Wonder why the connection just hangs forever

What is the expected behavior?
One of
1. Ignore the trailing whitespace and continue
2. Treat the hostname as invalid and emit an error

What went wrong?
The space was included in the hostname handed to the relay host, which then proceeded to do something dumb and uninformative with it

WebStore page: https://chrome.google.com/webstore/detail/secure-shell/pnhechapfaindjhompbnflcldabbghjo

Did this work before? N/A 

Chrome version: 58.0.3029.112  Channel: stable
OS Version: 9334.69.0
Flash Version: 25.0.0.171 

This was so frustrating, and only became apparent when a third party looked at the relay host's logs and identified what was going on
 

Comment 1 Deleted

Comment 2 by vapier@chromium.org, May 29 2017

Mergedinto: 713524
Status: Duplicate (was: Unconfirmed)
this has been fixed in nassh-0.8.36.4+ already

Sign in to add a comment