New issue
Advanced search Search tips

Issue 724336 link

Starred by 1 user
Status: Archived
Owner:
hungte@chromium.org
Closed: May 2017
Cc:
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

chromeos-setgoodfirmware returns "Invalid parameter name: startup_update_tries"

Project Member Reported by hungte@chromium.org, May 19 2017 
Chrome Version: ToT
OS: Chrome

What steps will reproduce the problem?
(1) Find a vboot1 device
(2) Initiate EC update, or make EC enter RO
(3) Reboot and wait for update_engine to invoke chromeos-setgoodfirmware

What is the expected result?
Continue updating EC

What happens instead?
Invalid parameter name: startup_update_tries
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/a7a05ed2e406d1f92bff55345598728e29fe7400

commit a7a05ed2e406d1f92bff55345598728e29fe7400
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri May 19 20:57:59 2017

chromeos-setgoodfirmware: Fix "Invalid parameter name: startup_update_tries"

The startup_update_tries was a function in firmware update utility
library, and must be changed to fwupdate_tries when converted to direct
crossystem invocation.

BUG= chromium:724336 
TEST=manually invoked chromeos-setgoodfirmware

Change-Id: Id445041e9988bf6cbedce4b215113b69af76e6f7
Reviewed-on: https://chromium-review.googlesource.com/508509
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/a7a05ed2e406d1f92bff55345598728e29fe7400/sbin/chromeos-setgoodfirmware

Comment 2 by hungte@chromium.org, May 30 2017

Status: Fixed (was: Started)

Comment 3 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment