Issue metadata
Sign in to add a comment
|
update_engine's GetKioskAppRequiredPlatformVersion D-Bus calls failing |
||||||||||||||||||||||
Issue descriptionhttps://groups.google.com/a/chromium.org/forum/#!topic/chromium-os-dev/EK2TFg27Nz0 reports that updates are failing on kiosk devices and this error is in the log: [0517/201726:ERROR:object_proxy.cc(582)] Failed to call method: org.chromium.LibCrosServiceInterface.GetKioskAppRequiredPlatformVersion: object_path= /org/chromium/LibCrosService: org.freedesktop.DBus.Error.UnknownMethod: Method "GetKioskAppRequiredPlatformVersion" with signature "" on interface "org.chromium.LibCrosServiceInterface" doesn't exist I think that this was probably broken by https://codereview.chromium.org/2798703002 for issue 703229 . That change should've made Chrome continue to export a GetKioskAppRequiredPlatformVersion method from org.chromium.LibCrosService, but it looks like it accidentally switched it to export GetRequiredPlatformVersion (which should've only been used for the new service). I'll upload a tiny Chrome fix if someone who uses this code wants to try it out.
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdf6f91b9e1c389bc6b07bdfb7eb9018ee49d719 commit cdf6f91b9e1c389bc6b07bdfb7eb9018ee49d719 Author: derat <derat@chromium.org> Date: Fri May 19 01:18:06 2017 chromeos: Export GetKioskAppRequiredPlatformVersion method. Continue to export a GetKioskAppRequiredPlatformVersion D-Bus method on org.chromium.LibCrosService. It was accidentally renamed to GetRequiredPlatformVersion (which should only be exported via the new org.chromium.KioskAppService service) by 6e2e787479f5. BUG= 703229 , 724325 Review-Url: https://codereview.chromium.org/2890293002 Cr-Commit-Position: refs/heads/master@{#473011} [modify] https://crrev.com/cdf6f91b9e1c389bc6b07bdfb7eb9018ee49d719/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
,
May 19 2017
This should be fixed now, but please comment or reopen if you're still seeing issues.
,
May 20 2017
,
Aug 1 2017
,
Aug 21 2017
It sounds like this change should get merged to 60. Issues seen on 60 are tracked in crbug.com/743262 . mnilsson@ can provide details for why it's needed.
,
Aug 21 2017
The issue is that this breaks the version pinning feature, (the ability for a kiosk app to specify the chromeos version it needs through the required-platform-version manifest field) Due to this bug, update_engine now fails to obtain the pinned version through this call, and then it assumes it is fine to update to 'latest'. This causes machines to update their OS version to levels that are not known to be working with the app. crbug.com/743262, comment 25 contains more google-internal background and justification.
,
Aug 22 2017
Harpreet, can you confirm this is working as expected in M61?
,
Aug 24 2017
mlight@ will test / verify on latest M61
,
Aug 29 2017
Any update on verifying this?
,
Aug 29 2017
ok, approving merge as per https://bugs.chromium.org/p/chromium/issues/detail?id=743262#c32
,
Aug 29 2017
,
Aug 29 2017
,
Aug 29 2017
Hmm. I got ready to do the merge today, but the suspected fix has been in 60 from the start. $ git find-releases cdf6f91b9 commit cdf6f91b9 was: initially in 60.0.3104.0 Sorry about noticing that just now; it appears that this can't be the fix for users still hitting this issue on M60.
,
Aug 29 2017
+ Xiyuan, I am not sure I am following the comments here. I assume the pinning issue got fixed and merged to M60?
,
Aug 29 2017
According to c#14, the fix CL already existed in M60 even before the branch hence this was not an issue on M60
,
Sep 1 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 4 2017
,
Jan 22 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by derat@chromium.org
, May 19 2017