New issue
Advanced search Search tips

Issue 724316 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug

Blocking:
issue 722827



Sign in to add a comment

DCHECK when dragging link and pressing escape

Project Member Reported by thomasanderson@chromium.org, May 18 2017

Issue description

Chromium 60.0.3104.0
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1) Drag a link to the tabstrip
(2) Press escape to cancel the DnD

What is the expected result?
The drag cancels and there's no DHCECK

What happens instead?

[1:1:0518/162614.524348:FATAL:MouseEventManager.cpp(778)] Check failed: event.Event().GetType() == WebInputEvent::kMouseMove. 
#0 0x7f5e1307b72b base::debug::StackTrace::StackTrace()
#1 0x7f5e1307a42c base::debug::StackTrace::StackTrace()
#2 0x7f5e130edfe3 logging::LogMessage::~LogMessage()
#3 0x7f5e017a8a85 blink::MouseEventManager::HandleDrag()
#4 0x7f5e017a91e7 blink::MouseEventManager::HandleMouseDraggedEvent()
#5 0x7f5e017961d6 blink::EventHandler::HandleMouseMoveOrLeaveEvent()
#6 0x7f5e0179638e blink::EventHandler::HandleMouseLeaveEvent()
#7 0x7f5dfd5e2ec5 blink::PageWidgetEventHandler::HandleMouseLeave()
#8 0x7f5dfd6b20b9 blink::WebViewImpl::HandleMouseLeave()
#9 0x7f5dfd5e2bc3 blink::PageWidgetDelegate::HandleInputEvent()
#10 0x7f5dfd6b5a11 blink::WebViewImpl::HandleInputEvent()
#11 0x7f5dfd6af6eb blink::WebViewFrameWidget::HandleInputEvent()
#12 0x7f5e0d4c3544 content::RenderWidgetInputHandler::HandleInputEvent()
#13 0x7f5e0d667275 content::RenderWidget::HandleInputEvent()
#14 0x7f5e0d64e6d5 content::RenderViewImpl::HandleInputEvent()
#15 0x7f5e0d4bd0d0 content::MainThreadEventQueue::HandleEventOnMainThread()
#16 0x7f5e0d4be60a content::QueuedWebInputEvent::Dispatch()
#17 0x7f5e0d4bcc06 content::MainThreadEventQueue::DispatchEvents()
#18 0x7f5e0d4c0067 _ZN4base8internal13FunctorTraitsIMN7content20MainThreadEventQueueEFvvEvE6InvokeIRK13scoped_refptrIS3_EJEEEvS5_OT_DpOT0_
#19 0x7f5e0d4bffb1 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN7content20MainThreadEventQueueEFvvEJRK13scoped_refptrIS5_EEEEvOT_DpOT0_
#20 0x7f5e0d4bff52 _ZN4base8internal7InvokerINS0_9BindStateIMN7content20MainThreadEventQueueEFvvEJ13scoped_refptrIS4_EEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#21 0x7f5e0d4bfe9c _ZN4base8internal7InvokerINS0_9BindStateIMN7content20MainThreadEventQueueEFvvEJ13scoped_refptrIS4_EEEEFvvEE3RunEPNS0_13BindStateBaseE
#22 0x7f5e13036f0e _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#23 0x7f5e1308137e base::debug::TaskAnnotator::RunTask()
#24 0x7f5dff786e0e blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#25 0x7f5dff783d96 blink::scheduler::TaskQueueManager::DoWork()
#26 0x7f5dff78f3c4 _ZN4base8internal13FunctorTraitsIMN5blink9scheduler16TaskQueueManagerEFvbEvE6InvokeIRKNS_7WeakPtrIS4_EEJRKbEEEvS6_OT_DpOT0_
#27 0x7f5dff78f2cf _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN5blink9scheduler16TaskQueueManagerEFvbERKNS_7WeakPtrIS6_EEJRKbEEEvOT_OT0_DpOT1_
#28 0x7f5dff78f243 _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvbEJNS_7WeakPtrIS5_EEbEEEFvvEE7RunImplIRKS7_RKSt5tupleIJS9_bEEJLm0ELm1EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#29 0x7f5dff78f15c _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvbEJNS_7WeakPtrIS5_EEbEEEFvvEE3RunEPNS0_13BindStateBaseE
#30 0x7f5e13036f0e _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#31 0x7f5e1308137e base::debug::TaskAnnotator::RunTask()
#32 0x7f5e13113e9d base::MessageLoop::RunTask()
#33 0x7f5e13114127 base::MessageLoop::DeferOrRunPendingTask()
#34 0x7f5e1311437d base::MessageLoop::DoWork()
#35 0x7f5e13126498 base::MessagePumpDefault::Run()
#36 0x7f5e131138d8 base::MessageLoop::Run()
#37 0x7f5e131bbedd base::RunLoop::Run()
#38 0x7f5e0d69d688 content::RendererMain()
#39 0x7f5e0dadf6dd content::RunZygote()
#40 0x7f5e0dadfa90 content::RunNamedProcessTypeMain()
#41 0x7f5e0dae1d6d content::ContentMainRunnerImpl::Run()
#42 0x7f5e0dade4da content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#43 0x7f5e1380ff91 service_manager::Main()
#44 0x7f5e0dadf48f content::ContentMain()
#45 0x55c7cb9aa938 ChromeMain
#46 0x55c7cb9aa852 main
#47 0x7f5df9152f45 __libc_start_main
#48 0x55c7cb9aa734 <unknown>

 
dnd_dcheck.mp4
1.7 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12dedc4fa09fc54ee6d0bd54d7ffde5c5ab2bdba

commit 12dedc4fa09fc54ee6d0bd54d7ffde5c5ab2bdba
Author: nzolghadr <nzolghadr@chromium.org>
Date: Wed May 24 22:29:36 2017

Account for mouse leave events in dragging flow

When mouse is outside of the page while dragging
if user presses Esc key we get a leave event
which seems correct logically. But the code was
not handling it properly.

BUG= 723207 ,  724316 

Review-Url: https://codereview.chromium.org/2900123002
Cr-Commit-Position: refs/heads/master@{#474450}

[add] https://crrev.com/12dedc4fa09fc54ee6d0bd54d7ffde5c5ab2bdba/third_party/WebKit/LayoutTests/fast/dnd/cancel-dragging-outside-page.html
[modify] https://crrev.com/12dedc4fa09fc54ee6d0bd54d7ffde5c5ab2bdba/third_party/WebKit/Source/core/input/MouseEventManager.cpp

Comment 2 by gab@chromium.org, May 25 2017

Blocking: 722827
Fixed?
Status: Fixed (was: Assigned)

Sign in to add a comment