Issue metadata
Sign in to add a comment
|
Try Bot labels have a lot of margin |
||||||||||||||||||
Issue description
The try bots currently use a lot of space due to their large margins and line-height.
I experimented a bit with the css and something like this looks better in my opinion:
.cr-buildbucket-view-0 .builder.cr-buildbucket-view {
margin: .1em .1rem;
line-height: 1.1;
}
,
May 18 2017
,
Jun 7 2017
,
Jun 8 2017
Yeah, the spacing between the boxes is definitely too large. This is because they all have padding on all four sides: it works nicely around the sides of the container, but doubles the desired space between them. Here's a CL to fix that, so they're now half as far apart: https://chromium-review.googlesource.com/c/528010/ I'm not going as far as you suggest, because removing all of that padding violates the guidelines in place elsewhere in the UI (e.g. how close together files or buttons are).
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/4545719396cecbd009bfc7cec937642649fc56e2 commit 4545719396cecbd009bfc7cec937642649fc56e2 Author: Aaron Gable <agable@chromium.org> Date: Thu Jun 08 20:55:42 2017 Halve spacing between builder elements This makes the spacing between elements equal to the padding around the edges of the container, instead of being double that width. Bug: 724313 Change-Id: I71af65381be8475515544f4f476b25c68f5233a0 Reviewed-on: https://chromium-review.googlesource.com/528010 Reviewed-by: Viktar Donich <viktard@google.com> [modify] https://crrev.com/4545719396cecbd009bfc7cec937642649fc56e2/src/main/resources/static/cr-buildbucket-view.html
,
Jun 8 2017
Fix landed, waiting on import and deploy.
,
Jun 8 2017
,
Jun 8 2017
Imported, marking fixed, can verify when deployed. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by logan@google.com
, May 18 2017Labels: Proj-Gerrit-Migration