[root layer scrolls] stop calling FrameView::CalculateScrollbarModes from PLSA |
||
Issue descriptionHaving the root PLSA call FrameView::CalculateScrollbarModes was kind of a hack, and r467207 added more call sites. We should move the CalculateScrollbarModes logic to someplace like LayoutView to make it more cleanly separated from FrameView-scrolling.
,
May 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c38965c165d21706028861200fab06b1eca0bea commit 1c38965c165d21706028861200fab06b1eca0bea Author: skobes <skobes@chromium.org> Date: Mon May 22 21:13:47 2017 Move CalculateScrollbarModes from FrameView to LayoutView. This is a better place given that it is used by both FrameView and the root PaintLayerScrollableArea. SetCanHaveScrollbars remains on FrameView, but with a comment to clarify that it is RLS-aware. BUG= 724309 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2900513002 Cr-Commit-Position: refs/heads/master@{#473695} [modify] https://crrev.com/1c38965c165d21706028861200fab06b1eca0bea/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/1c38965c165d21706028861200fab06b1eca0bea/third_party/WebKit/Source/core/frame/FrameView.h [modify] https://crrev.com/1c38965c165d21706028861200fab06b1eca0bea/third_party/WebKit/Source/core/layout/LayoutView.cpp [modify] https://crrev.com/1c38965c165d21706028861200fab06b1eca0bea/third_party/WebKit/Source/core/layout/LayoutView.h [modify] https://crrev.com/1c38965c165d21706028861200fab06b1eca0bea/third_party/WebKit/Source/core/page/SpatialNavigation.cpp [modify] https://crrev.com/1c38965c165d21706028861200fab06b1eca0bea/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
,
May 22 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 19 2017