New issue
Advanced search Search tips

Issue 724309 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 417782



Sign in to add a comment

[root layer scrolls] stop calling FrameView::CalculateScrollbarModes from PLSA

Project Member Reported by skobes@chromium.org, May 18 2017

Issue description

Having the root PLSA call FrameView::CalculateScrollbarModes was kind of a hack, and r467207 added more call sites.  We should move the CalculateScrollbarModes logic to someplace like LayoutView to make it more cleanly separated from FrameView-scrolling.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6130f3dd3af923ec847c32372351495d5b8878fd

commit 6130f3dd3af923ec847c32372351495d5b8878fd
Author: skobes <skobes@chromium.org>
Date: Fri May 19 05:46:28 2017

Kill ScrollbarModesCalculationStrategy.

This was added in http://crrev.com/9de09a32, but I don't think it makes sense
anymore.  Its purpose is to include child frames in FV::scrollable_areas_ even
if their scrollbars have been suppressed by FV::SetCanHaveScrollbars(false).
But such frames are not scrollable by user input (see FV::UserInputScrollable
which examines the ScrollbarMode values), so there is no need for them to be in
FV::scrollable_areas_.

BUG= 724309 

Review-Url: https://codereview.chromium.org/2894733002
Cr-Commit-Position: refs/heads/master@{#473100}

[modify] https://crrev.com/6130f3dd3af923ec847c32372351495d5b8878fd/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/6130f3dd3af923ec847c32372351495d5b8878fd/third_party/WebKit/Source/core/frame/FrameView.h

Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2017

Comment 3 by skobes@chromium.org, May 22 2017

Status: Fixed (was: Started)

Sign in to add a comment