New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724297 link

Starred by 1 user
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: May 2017
Cc:
█ ranjitkan@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Transparent windows stopped working with --diable-gpu

Project Member Reported by thomasanderson@chromium.org, May 18 2017 
Google Chrome 59.0.3071.61 beta
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1) Launch Chrome with --disable-gpu
(2) Drag a link from a web page

What is the expected result?
The rounded rectangle shouldn't render anything in the corners.

What happens instead?
It renders white pixels in the corners.
Screenshot from 2017-05-18 15:37:39.png
74.8 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53f95703f2ce29b492ad6491b637a46d2c2c0ef2

commit 53f95703f2ce29b492ad6491b637a46d2c2c0ef2
Author: thomasanderson <thomasanderson@chromium.org>
Date: Fri May 19 01:39:07 2017

Initialize GpuDataManagerImpl after GpuDataManagerVisualProxy

Transparent visuals became broken in software rendering mode after
[1], which caused GpuDataManagerVisualProxy to stop getting the
initial OnGpuInfoUpdate() from GpuDataManagerImpl.  This CL moves the
initialization of GDMI after GDMVP so this cannot happen.

[1] https://codereview.chromium.org/2805933002

R=piman@chromium.org
BUG= 724297 

Review-Url: https://codereview.chromium.org/2892093002
Cr-Commit-Position: refs/heads/master@{#473021}

[modify] https://crrev.com/53f95703f2ce29b492ad6491b637a46d2c2c0ef2/content/browser/browser_main_loop.cc

Comment 2 by thomasanderson@chromium.org, May 19 2017

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, May 20 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, May 20 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8ad653f246a455805093499bd5e673db9ebb987

commit b8ad653f246a455805093499bd5e673db9ebb987
Author: thomasanderson <thomasanderson@chromium.org>
Date: Sat May 20 01:56:57 2017

[Merge to M59] Initialize GpuDataManagerImpl after GpuDataManagerVisualProxy

> Transparent visuals became broken in software rendering mode after
> [1], which caused GpuDataManagerVisualProxy to stop getting the
> initial OnGpuInfoUpdate() from GpuDataManagerImpl.  This CL moves the
> initialization of GDMI after GDMVP so this cannot happen.
>
> [1] https://codereview.chromium.org/2805933002
>
> R=piman@chromium.org
> BUG= 724297 
>
> Review-Url: https://codereview.chromium.org/2892093002
> Cr-Commit-Position: refs/heads/master@{#473021}

TBR=piman@chromium.org
BUG= 724297 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2894673009
Cr-Commit-Position: refs/branch-heads/3071@{#642}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/b8ad653f246a455805093499bd5e673db9ebb987/content/browser/browser_main_loop.cc

Comment 5 by thomasanderson@chromium.org, May 20 2017

Status: Fixed (was: Started)

Comment 6 by ranjitkan@chromium.org, May 24 2017

Cc: ranjitkan@chromium.org
Labels: TE-Verified-59.0.3071.71 TE-Verified-M59
Rechecked this on Ubuntu 14.04 using chrome version 59.0.3071.71 by disabling the flag.  Fix is working as intended. Attached a screen shot for the same.

Adding TE-Verified labels.

Thanks.!
No White Border.png
36.7 KB View Download
►

Sign in to add a comment