New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724289 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Drop support for obsolete Android USB Type-C dual-role class support

Project Member Reported by groeck@chromium.org, May 18 2017

Issue description

Android Type-C Dual-role class support is not enabled in Chrome OS. The code is obsolete and has been replaced upstream with a different infrastructure. Drop it instead of carrying it around.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2017

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/dcb46f2cfd11578e700f20313739eeaca81532fa

commit dcb46f2cfd11578e700f20313739eeaca81532fa
Author: Guenter Roeck <groeck@chromium.org>
Date: Fri May 19 23:19:35 2017

CHROMIUM: Revert "ANDROID: usb: dual-role: make stub functions inline"

This reverts commit ce4de072a48ed4767a8fbd808a39d0d7a5fbbfc7.

Code is unused and obsolete.

BUG= chromium:724289 
TEST=Build image and test on Kevin

Change-Id: I0c9b925e1e02280f3181c3371d91b65cd81cf59e
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/508877
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>

[modify] https://crrev.com/dcb46f2cfd11578e700f20313739eeaca81532fa/include/linux/usb/class-dual-role.h

Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2017

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/d2cd583a8972167e746545bb65c40d4391a7fd9a

commit d2cd583a8972167e746545bb65c40d4391a7fd9a
Author: Guenter Roeck <groeck@chromium.org>
Date: Fri May 19 23:19:36 2017

CHROMIUM: Revert "usb: phy: Dual role sysfs class definition"

This reverts commit ce31762e99a3a75edb10d053dd71ec02bbe7aaa5.

Revert "usb: phy: fix dual role sysfs build if kernel modules are supported"
This reverts commit b9efd37bc8c01458a81d5b142e4b2259465a3c51.

Code is unused and obsolete.

BUG= chromium:724289 
TEST=Build image and test on Kevin

Change-Id: Ie35348cdc057028f9829a1bd572d697dbd000e1b
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/508879
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>

[delete] https://crrev.com/dcb46f2cfd11578e700f20313739eeaca81532fa/include/linux/usb/class-dual-role.h
[modify] https://crrev.com/d2cd583a8972167e746545bb65c40d4391a7fd9a/drivers/usb/phy/Kconfig
[delete] https://crrev.com/dcb46f2cfd11578e700f20313739eeaca81532fa/drivers/usb/phy/class-dual-role.c
[delete] https://crrev.com/dcb46f2cfd11578e700f20313739eeaca81532fa/Documentation/ABI/testing/sysfs-class-dual-role-usb
[modify] https://crrev.com/d2cd583a8972167e746545bb65c40d4391a7fd9a/drivers/usb/phy/Makefile

Comment 3 by groeck@chromium.org, May 20 2017

Status: Fixed (was: Started)
Labels: M-60
Cc: vpalatin@chromium.org diand...@chromium.org groeck@chromium.org
 Issue 625263  has been merged into this issue.
Cc: amstan@chromium.org briannorris@chromium.org smbar...@chromium.org

Comment 7 by amstan@google.com, Jul 10 2017

> Android Type-C Dual-role class support is not enabled in Chrome OS. The code is obsolete and has been replaced upstream with a different infrastructure. Drop it instead of carrying it around.

Do we have that upstream infrastructure in our 4.4 tree? It would be nice to know what I can do re b/36564896. Or if it's totally a lost cause due to this.

Comment 8 by groeck@chromium.org, Jul 10 2017

#7: Not sure I understand; the Android infrastructure was not enabled in the first place. Effectively I only removed disabled code. What part of it are you looking for ? Did you plan to enable it ? If so, did you have a plan for later kernels ?

Answering your question: The new infrastructure is not currently in 4.4, though I have it in a local tree. If needed I could make it available.

Note that the new infrastructure, just like the Android infrastructure, is primarily a user space ABI. Having it available doesn't help much without matching user space component.

Comment 9 by amstan@chromium.org, Jul 12 2017

> Do we have that upstream infrastructure in our 4.4 tree? It would be nice to know what I can do re b/36564896. Or if it's totally a lost cause due to this.

> Not sure I understand; the Android infrastructure was not enabled in the first place.

Yep, no problem then. I never intended to use the Android infrastructure. I didn't realize it was Android only (and that we didn't care about it).

Sign in to add a comment