New issue
Advanced search Search tips

Issue 724287 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move enum UseCounter::Feature to somewhere shared both with Blink and chromium

Project Member Reported by lunalu@chromium.org, May 18 2017

Issue description

We are planning to move UseCounter code to the browser side to solve problem such as OOPIS and UKM UseCounter. This requires access to UseCounter::Feature outside of Blink.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47be21fa9c0e81c2fdb2ab57002e08152cde13a0

commit 47be21fa9c0e81c2fdb2ab57002e08152cde13a0
Author: Luna Lu <lunalu@chromium.org>
Date: Fri Jun 02 16:35:15 2017

Replace UseCounter::Feature by WebFeature in workers

Script used (in WebKit/Source/core/workers/, and WebKit/Source/web/):
for f in $(find -name "*.cpp" -or -name "*.h"); do
  ### Replace enum values UseCounter::kFeatureName by WebFeature::kFeatureName
  sed -i 's/UseCounter::k/WebFeature::k/g' "$f"
  sed -i ':a;N;!ba;s/UseCounter::\n\s*k/WebFeature::k/g' "$f"
  ### Replace enum type UseCounter::Feature by WebFeature
  sed -i 's/UseCounter::Feature/WebFeature/g' "$f"
  ### To use BitVector, we need casting WebFeature(no implicit conversion for enum classs)
  sed -i ‘s/QuickSet(feature/QuickSet(static_cast<int>(feature)/g’ $f
  sed -i ‘s/QuickGet(feature/QuickGet(static_cast<int>(feature)/g’ $f
  sed -i ‘s/reported_features_(WebFeature::kNumberOfFeatures)/reported_features_(static_cast<int>(WebFeature::kNumberOfFeatures))/g’ $f
done

In addition:
WebSharedWorkerImpl calling 
WebSharedWorkerClient::CountFeature(uint32_t) needed casting

This CL also fixed mistakes made in previous CL
(https://codereview.chromium.org/2894063002):
in core/frame/Deprecation*, should define methods using WebFeature and overload
methods with UseCounter::Feature, not the other way around.
in core/frame/UseCounter*, missed converting two methods to use 
WebFeature instead

Bug:  724287 
Change-Id: Ib39c2e44e88eaa463a316cc562fbceb5a4651bbc
Reviewed-on: https://chromium-review.googlesource.com/519782
Commit-Queue: Luna Lu <lunalu@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476689}
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/frame/Deprecation.h
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/SharedWorker.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.h
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.h
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/Worker.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/web/WebSharedWorkerReportingProxyImpl.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/web/WebSharedWorkerReportingProxyImpl.h
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/47be21fa9c0e81c2fdb2ab57002e08152cde13a0/third_party/WebKit/Source/web/tests/WebViewTest.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adecd2e280ac77cbad0c8412c04747fed833deb9

commit adecd2e280ac77cbad0c8412c04747fed833deb9
Author: Luna Lu <lunalu@chromium.org>
Date: Wed Jun 07 18:11:58 2017

Reformat UseCounter code

This CL reformat code of the format:
if/else/etc (..) 
   ...
   UseCounter::kFeatureName
   ...

to 
if/else/etc (..) {
   ...
   UseCounter::kFeatureName
   ...
}

In CL https://chromium-review.googlesource.com/c/524144/,
UseCounter::kFeatureName will be replaced by
WebFeature::kFeatureName. This CL fixes the presubmit error
(check-webkit-style) for  issue 524144 .

Bug:  724287 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I12b81c75d5ecab32943b788676e0c087719ec650
Reviewed-on: https://chromium-review.googlesource.com/524187
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luna Lu <lunalu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477706}
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/css/StyleSheetList.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/dom/ElementFullscreen.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/dom/PseudoElement.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/dom/StyleEngineContext.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/frame/csp/CSPSource.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/html/imports/HTMLImportsController.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/page/PointerLockController.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/paint/ThemePainter.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/modules/filesystem/Entry.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/modules/peerconnection/RTCIceCandidate.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/adecd2e280ac77cbad0c8412c04747fed833deb9/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d

commit 6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d
Author: Luna Lu <lunalu@chromium.org>
Date: Wed Jun 07 23:28:15 2017

Replace UseCounter::Feature by WebFeature in Blink

Script used in third_party/WebKit/
for f in $(find -name "*.cpp" -or -name "*.h"); do
  ### Replace enum values UseCounter::kFeatureName by WebFeature::kFeatureName
  sed -i 's/UseCounter::k/WebFeature::k/g' "$f"
  sed -i ':a;N;!ba;s/UseCounter::\n\s*k/WebFeature::k/g' "$f"
  ### Replace enum type UseCounter::Feature by WebFeature
  sed -i 's/UseCounter::Feature /WebFeature /g' "$f"
  ### Undo changes to UseCounter::Context
  sed -i 's/WebFeature::kDefaultContext/UseCounter::kDefaultContext/g' "$f"
  sed -i 's/WebFeature::kSVGImageContext/UseCounter::kSVGImageContext/g' "$f"
  sed -i 's/WebFeature::kExtensionContext/UseCounter::kExtensionContext/g' "$f"
  sed -i 's/WebFeature::kDisabledContext/UseCounter::kDisabledContext/g' "$f"
done

Additional changes in *Internals.cpp:
  static_cast<uint32_t>(WebFeature::kNumberOfFeatures) *bi_opt* feature

Additional changes in UseCounter.h, UseCounter.cpp, Deprecation.h

A few additional casting is also added.

Bug:  724287 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0e18a017542c4d6bb5ddf0f50a3522dfe115dba1
Reviewed-on: https://chromium-review.googlesource.com/524144
Commit-Queue: Luna Lu <lunalu@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477785}
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/core/v8/BindingSecurityTest.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/core/v8/UseCounterCallback.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/CSSMatrix.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/StyleSheetList.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/parser/CSSAtRuleID.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/parser/CSSParserContext.h
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICursor.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetAnchor.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapCoordinate.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransform.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationNameUtils.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/properties/CSSPropertyLengthUtils.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/ClassicScript.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/ElementFullscreen.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/MessagePort.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/PseudoElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/SinkDocument.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/StyleEngineContext.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/editing/commands/DocumentExecCommand.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/events/Event.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/events/EventDispatcher.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/events/EventTarget.h
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/events/TouchEvent.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/events/TouchEventTest.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/events/VisualViewportResizeEvent.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/events/VisualViewportScrollEvent.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/exported/SharedWorkerRepositoryClientImpl.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/fileapi/Blob.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/fileapi/File.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/fileapi/URLFileAPI.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/frame/DOMWindow.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/frame/Deprecation.h
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/frame/UseCounterTest.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/frame/csp/CSPSource.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/FormData.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLBodyElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLContentElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLDataListElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLMapElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLMeterElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLOListElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLPictureElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLShadowElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLTableCellElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLTablePartElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLUnknownElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/HTMLViewSourceDocument.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/ImageDocument.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/PluginDocument.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/TextControlElement.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/TextDocument.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/canvas/ImageElementBase.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/DateInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/DateTimeLocalInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/EmailInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/FileInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/InputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/InputType.h
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/MonthInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/NumberInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/PasswordInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/SubmitInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/TelephoneInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/TextInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/TimeInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/URLInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/forms/WeekInputType.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/imports/HTMLImportsController.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/media/MediaDocument.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/layout/LayoutImage.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/layout/LayoutRuby.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/6a083acfb8ce7c4d8011a0c9c9c8bb703e4b216d/third_party/WebKit
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f56c8399b546327995e9581b10e93b8253dd6ee

commit 6f56c8399b546327995e9581b10e93b8253dd6ee
Author: Luna Lu <lunalu@chromium.org>
Date: Fri Jun 09 19:37:32 2017

Move feature definition from UseCounterFeature.def to WebFeature.h

Changes:
move feature definition;
update presubmit checker;
remove use_counter_feature from WATCHLISTS

Note: this CL will be committed after https://chromium-review.googlesource.com/c/524144/

Bug:  724287 
Change-Id: Ib06619c4d5530aeebe91083625a8dbf383995f14
Reviewed-on: https://chromium-review.googlesource.com/527400
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Luna Lu <lunalu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478373}
[modify] https://crrev.com/6f56c8399b546327995e9581b10e93b8253dd6ee/WATCHLISTS
[modify] https://crrev.com/6f56c8399b546327995e9581b10e93b8253dd6ee/third_party/WebKit/public/platform/PRESUBMIT.py
[delete] https://crrev.com/01b3ff8dd7b21723108b7802164f3a8fa64dabce/third_party/WebKit/public/platform/UseCounterFeature.def
[modify] https://crrev.com/6f56c8399b546327995e9581b10e93b8253dd6ee/third_party/WebKit/public/platform/WebFeature.h
[modify] https://crrev.com/6f56c8399b546327995e9581b10e93b8253dd6ee/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/6f56c8399b546327995e9581b10e93b8253dd6ee/tools/metrics/histograms/update_use_counter_feature_enum.py

Status: Fixed (was: Assigned)

Comment 6 by rbyers@chromium.org, Jul 18 2017

Owner: loonyb...@chromium.org

Sign in to add a comment