New issue
Advanced search Search tips

Issue 724282 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
eugene...@chromium.org
kkhorimoto@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Track whether web usage should be enabled/disabled for WebStateLists deserialized by BrowserListSessionServiceImpl

Project Member Reported by kkhorimoto@chromium.org, May 18 2017 
TabModel maintains a |webUsageEnabled_| bool which is defined for all WebStates in its associated WebStateList. https://codereview.chromium.org/2894553003 introduces a mechanism where TabModel's value is passed to all deserialized WebStates that are created by that TabModel; we should consider whether we need this same mechanism for BrowserList deserialization.
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd2aa6510e3b05e4ca3816a1b0e42ca59f3051dd

commit fd2aa6510e3b05e4ca3816a1b0e42ca59f3051dd
Author: sdefresne <sdefresne@chromium.org>
Date: Tue May 23 14:23:10 2017

[ios] Clean how WebUsageEnabled flag is restored for WebStateList.

The WebStateList deserialisation function DeserializeWebStateList takes
a factory function that can makes arbitrary change to the WebState after
it has been created.

Move the code setting the WebUsageEnabled flag to the factory function
instead of passing it as an extra flag to the deserialization function.

Rename TabModel ivar from webUsageEnabled_ to _webUsageEnabled
for consistency with the other ivars that use the new convention.

BUG=724282

Review-Url: https://codereview.chromium.org/2900643003
Cr-Commit-Position: refs/heads/master@{#473886}

[modify] https://crrev.com/fd2aa6510e3b05e4ca3816a1b0e42ca59f3051dd/ios/chrome/browser/tabs/tab_model.mm
[modify] https://crrev.com/fd2aa6510e3b05e4ca3816a1b0e42ca59f3051dd/ios/chrome/browser/web_state_list/web_state_list_serialization.h
[modify] https://crrev.com/fd2aa6510e3b05e4ca3816a1b0e42ca59f3051dd/ios/chrome/browser/web_state_list/web_state_list_serialization.mm
[modify] https://crrev.com/fd2aa6510e3b05e4ca3816a1b0e42ca59f3051dd/ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm
[modify] https://crrev.com/fd2aa6510e3b05e4ca3816a1b0e42ca59f3051dd/ios/shared/chrome/browser/ui/browser_list/browser_list_session_service_factory.mm
[modify] https://crrev.com/fd2aa6510e3b05e4ca3816a1b0e42ca59f3051dd/ios/shared/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm

Comment 2 by eugene...@chromium.org, May 30 2017

Components: -Mobile>WebView>Glue
Labels: -Type-Bug Type-Task
Per description, this is outside of Mobile>WebView>Glue scope

Comment 3 by sdefresne@chromium.org, May 31 2017

Components: -UI>Browser>Core Internals

Comment 4 by eugene...@chromium.org, Aug 25 2017

Components: -Internals UI>Browser>Sessions

Comment 5 by sdefresne@chromium.org, Jun 11 2018

Owner: ----
Status: Available (was: Assigned)
►

Sign in to add a comment