Add UMA metrics for linux distro |
||||
Issue descriptionGetLinuxDistro() in src/base/linux_util.* returns the output of 'lsb_release -d'. Currently this is called on each startup from ChromeBrowserMainPartsLinux::PreProfileInit(). We should log the distro using UMA the first time the distro codename is obtained.
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcd78795faa1db43a347464fa235ead2a186636b commit fcd78795faa1db43a347464fa235ead2a186636b Author: timbrown <timbrown@chromium.org> Date: Tue May 30 20:21:45 2017 Add UMA metrics for the linux distro. At this point, only included the distros that are currently supported both by us and the distro maker. For example, Ubuntu 15.10 is not included as it is no longer supported by Ubuntu. If there is a large UNKNOWN usage, then we can try to add other popular distros, such as Mint. BUG= 724244 R=rkaplow@chromium.org,thomasanderson@chromium.org Review-Url: https://codereview.chromium.org/2902853002 Cr-Commit-Position: refs/heads/master@{#475653} [modify] https://crrev.com/fcd78795faa1db43a347464fa235ead2a186636b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc [modify] https://crrev.com/fcd78795faa1db43a347464fa235ead2a186636b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_unittest.cc [modify] https://crrev.com/fcd78795faa1db43a347464fa235ead2a186636b/tools/metrics/histograms/enums.xml [modify] https://crrev.com/fcd78795faa1db43a347464fa235ead2a186636b/tools/metrics/histograms/histograms.xml
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3612567b1d18726aa2acc3b477c615f98c016c0a commit 3612567b1d18726aa2acc3b477c615f98c016c0a Author: timbrown <timbrown@chromium.org> Date: Thu Jun 01 23:20:15 2017 Unify if guards of GetLinuxWindowManager. This comes from a review comment on http://crrev.com/2917483002. The if guard on the function call to GetLinuxWindowManager is no longer the same as the guard of the function definition. This CL makes them the same again. BUG= 724244 R=thestig@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ozone_compile_only_ng Review-Url: https://codereview.chromium.org/2914963003 Cr-Commit-Position: refs/heads/master@{#476481} [modify] https://crrev.com/3612567b1d18726aa2acc3b477c615f98c016c0a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ef3c75f17b73788b519f9c4077cc2beccdd308f commit 9ef3c75f17b73788b519f9c4077cc2beccdd308f Author: Tim Brown <timbrown@chromium.org> Date: Tue Jul 11 19:41:50 2017 Detect more linux distros for metrics We now correctly detect openSUSE Leap 42.2. The new versions of debian and Fedora have also been added, along with (non-versioned) detection of several popular distros which are not officially supported. Bug: 724244 Change-Id: Id6bf8dc8fb0247769d2da49eea121927dfe4dbf9 Reviewed-on: https://chromium-review.googlesource.com/565959 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#485694} [modify] https://crrev.com/9ef3c75f17b73788b519f9c4077cc2beccdd308f/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc [modify] https://crrev.com/9ef3c75f17b73788b519f9c4077cc2beccdd308f/tools/metrics/histograms/enums.xml
,
Jul 11 2017
,
Sep 21 2017
Given this is proposing to add a new string to UMA proto, please make sure to get chrome-privacy@ to sign off. (I suspect it should be fine, but we should get their sign off to make sure.)
,
Sep 21 2017
,
Dec 9 2017
We are scrapping the idea of adding a string to UMA proto. Will just use a histogram instead.
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ae5e682de79abafd24549e3aed76ce523562629 commit 9ae5e682de79abafd24549e3aed76ce523562629 Author: Tim Brown <timbrown@chromium.org> Date: Mon Dec 11 22:19:11 2017 Update distro histogram For supported distros, group the versions together so that we can more easily see them together (include some spare ID range for each distro too). Also add in a couple of future versions so that we don't have to keep on updating the metrics. Downside is that the old histogram values are deprecated and will take a while to settle on the new values as newer versions roll out. Bug: 724244 Change-Id: I74f1c704529856ccb946178f035e8baed5212ecc Reviewed-on: https://chromium-review.googlesource.com/818203 Commit-Queue: Tim Brown <timbrown@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#523230} [modify] https://crrev.com/9ae5e682de79abafd24549e3aed76ce523562629/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc [modify] https://crrev.com/9ae5e682de79abafd24549e3aed76ce523562629/tools/metrics/histograms/enums.xml
,
Dec 11 2017
The list of distros should cover us for the next ~18 months. Marking as fixed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, May 23 2017