New issue
Advanced search Search tips

Issue 724243 link

Starred by 1 user
Status: Fixed
Owner:
carlosk@chromium.org
Closed: May 2017
Cc:
slangley@chromium.org
jbroman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

editing/selection/selection-plugin-clear-crash.html failing on "WebKit Linux Trusty Leak"

Project Member Reported by carlosk@chromium.org, May 18 2017 
Since build # 4790 on "WebKit Linux Trusty Leak" the editing/selection/selection-plugin-clear-crash.html layout test has been consistently failing due to leakage with this log:

({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,13],"numberOfLiveSuspendableObjects":[2,3]})

FindIt couldn't find anything (aren't layout tests supported?). I'm checking out the code now to confirm and search for the culprit CL.

[1] https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/4790

Comment 1 by carlosk@chromium.org, May 18 2017

Cc: slangley@chromium.org jbroman@chromium.org
Owner: carlosk@chromium.org
Status: Assigned (was: Untriaged)
Running that layout tests locally with the --enable-leak-detection  parameter resulted in a crash instead of a leak report as I see in the bot:

Check failed: !web_plugin_. 
#0 0x7fa8c6d5c77b base::debug::StackTrace::StackTrace()
#1 0x7fa8c6d5b47c base::debug::StackTrace::StackTrace()
#2 0x7fa8c6dcf033 logging::LogMessage::~LogMessage()
#3 0x7fa8ba97b9b9 blink::WebPluginContainerImpl::~WebPluginContainerImpl()
#4 0x7fa8ba85cd14 blink::GarbageCollectedFinalized<>::FinalizeGarbageCollectedObject()
#5 0x7fa8ba85cce5 blink::FinalizerTraitImpl<>::Finalize()
#6 0x7fa8ba8c6d95 blink::FinalizerTrait<>::Finalize()
#7 0x7fa8bcc3cf71 blink::HeapObjectHeader::Finalize()
#8 0x7fa8bcc44540 blink::NormalPage::Sweep()
#9 0x7fa8bcc3e369 blink::BaseArena::SweepUnsweptPage()
#10 0x7fa8bcc3e9b0 blink::BaseArena::CompleteSweep()
#11 0x7fa8bcc4e9e1 blink::ThreadState::CompleteSweep()
#12 0x7fa8bcc55f8f blink::ThreadState::PreSweep()
#13 0x7fa8bcc4f628 blink::ThreadState::CollectGarbage()
#14 0x7fa8bde83494 blink::V8GCController::GcEpilogue()
#15 0x7fa8c0e21059 v8::internal::Heap::CallGCEpilogueCallbacks()
#16 0x7fa8c0e22d6f v8::internal::Heap::PerformGarbageCollection()
#17 0x7fa8c0e2177a v8::internal::Heap::CollectGarbage()
#18 0x7fa8c0e2043a v8::internal::Heap::CollectAllGarbage()
#19 0x7fa8bde83c38 blink::V8GCController::CollectAllGarbageForTesting()
#20 0x7fa8ba948141 blink::(anonymous namespace)::WebLeakDetectorImpl::CollectGarbageAndReport()
#21 0x000000d296c0 content::LeakDetector::TryLeakDetection()
#22 0x000000d1c386 content::BlinkTestRunner::OnTryLeakDetection()
#23 0x000000c965b1 _ZN4base20DispatchToMethodImplIPN7content23LayoutTestMessageFilterEMS2_FvvERKSt5tupleIJEEJEEEvRKT_T0_OT1_NS_13IndexSequenceIJXspT2_EEEE
(...)

Culprit CL is https://codereview.chromium.org/2886113002 which was already reverted by jbroman@.

Will mark as fixed once we confirm the bot runs a green build.

Comment 2 by carlosk@chromium.org, May 18 2017

Status: Fixed (was: Assigned)
Fixed in build #4796 due to revert https://codereview.chromium.org/2888283004/.
►

Sign in to add a comment