New issue
Advanced search Search tips

Issue 724228 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] RemotingClient leakage

Project Member Reported by yuweih@chromium.org, May 18 2017

Issue description

RemotingClient never gets released after the session ends.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b366b970abadb9d9f05ef314da12973fb831f24

commit 2b366b970abadb9d9f05ef314da12973fb831f24
Author: yuweih <yuweih@chromium.org>
Date: Thu May 18 23:28:42 2017

[CRD iOS] Fix the leaky RemotingClient

Previously RemotingClient was not able to clean up itself after the session
ended due to retain loops.

This CL fixed the retain loops and other thread issues hidden by the fact that
RemotingClient and its resources were not released after the session ends.

BUG= 724228 

Review-Url: https://codereview.chromium.org/2886233003
Cr-Commit-Position: refs/heads/master@{#472965}

[modify] https://crrev.com/2b366b970abadb9d9f05ef314da12973fb831f24/remoting/ios/app/host_view_controller.mm
[modify] https://crrev.com/2b366b970abadb9d9f05ef314da12973fb831f24/remoting/ios/app/remoting_view_controller.mm
[modify] https://crrev.com/2b366b970abadb9d9f05ef314da12973fb831f24/remoting/ios/display/gl_display_handler.mm
[modify] https://crrev.com/2b366b970abadb9d9f05ef314da12973fb831f24/remoting/ios/session/remoting_client.mm
[modify] https://crrev.com/2b366b970abadb9d9f05ef314da12973fb831f24/remoting/ios/session/remoting_client_session_delegate.h

Comment 2 by yuweih@chromium.org, May 19 2017

Status: Fixed (was: Assigned)

Sign in to add a comment