New issue
Advanced search Search tips

Issue 724212 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Update credentialmanager LayoutTests to use shared "resource" file

Reported by m...@mikepennisi.com, May 18 2017

Issue description

The following credentialmanager LayoutTests currently depend on WebIDL utility
script in the `serviceworker` directory:

- http/tests/credentialmanager/credentialscontainer-basics.html
- http/tests/credentialmanager/credentialscontainer-get-basics.html
- http/tests/credentialmanager/federatedcredential-basics.html
- http/tests/credentialmanager/passwordcredential-basics.html

This utility script is no longer needed by any tests within the `serviceworker`
directory and will shortly be re-located to the `credentialmanager/resources`
directory. However, the `http/tests/resources/idlharness.js` file is intended
for re-use across all LayoutTests; the credentialmanager tests referenced above
should be re-factored to use that script.
 
Components: Blink>LayoutTests
Labels: -Type-Bug Type-Task
Owner: ellyjo...@chromium.org
Status: Assigned (was: Unconfirmed)
note to self: nag mike on IRC to do this :)
Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dca85dac110e00bb8a22e1b9d94fb44d44b2d518

commit dca85dac110e00bb8a22e1b9d94fb44d44b2d518
Author: mike <mike@mikepennisi.com>
Date: Thu May 18 20:36:28 2017

Upstream service worker tests to WPT

**install-event-type-worker**

This test is nearly identical to the version available in the Web
Platform Tests project. Update the upstream version with the only
meaningful difference between the tests: an additional assertion for the
event object provided to the service worker's `oninstall` event handler.
Extend assertions with description strings to aid debugging in case of
test failure.

**interfaces**

Extend the upstream version with the additional assertions found in the
Chromium-specific version. Remove the Chromium-specific version.
Re-locate the associated "resource" file as it is reference by
unrelated tests.

**invalid-blobtype**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Simplify script resource URLs in the upstream version.

**invalid-header**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Simplify script resource URLs in the upstream version.

**multiple-register**

Remove the Chromium-specific version because it is equivalent to the
upstream version. Correct a typo in an assertion message in the upstream
version.

BUG= 688116 ,  724212 
R=mek@chromium.org

Review-Url: https://codereview.chromium.org/2865313003
Cr-Commit-Position: refs/heads/master@{#472916}

[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/invalid-blobtype.https.html
[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/invalid-header.https.html
[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/multiple-register.https.html
[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/install-event-type-worker.js
[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/interfaces-worker.sub.js
[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/invalid-blobtype-iframe.https.html
[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/invalid-header-iframe.https.html
[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-basics.html
[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-errors.html
[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html
[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html
[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch.html
[modify] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-redirect.html
[rename] https://crrev.com/dca85dac110e00bb8a22e1b9d94fb44d44b2d518/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/interfaces.js
[delete] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/LayoutTests/http/tests/serviceworker/install-event-type.html
[delete] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/LayoutTests/http/tests/serviceworker/interfaces.html
[delete] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/LayoutTests/http/tests/serviceworker/invalid-blobtype.html
[delete] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/LayoutTests/http/tests/serviceworker/invalid-header.html
[delete] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/LayoutTests/http/tests/serviceworker/multiple-register.html
[delete] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/install-event-type-worker.js
[delete] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js
[delete] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/invalid-blobtype-iframe.html
[delete] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/invalid-blobtype-worker.js
[delete] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/invalid-header-iframe.html
[delete] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/invalid-header-worker.js

Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e11116938aaefd39902c8441f25bd3e230e9c487

commit e11116938aaefd39902c8441f25bd3e230e9c487
Author: mike <mike@mikepennisi.com>
Date: Tue May 30 14:21:02 2017

[credentialsmanager] Remove redundant tests

These assertions have been implemented in the Web Platform Tests
project. There, they are expressed with the `testharness.js` library,
which is more thorough than the locally-defined `verify_interface`
utility function. Remove the Chromium-specific assertions in favor of
those in the shared tests, and remove the now-unused `verify_interface`
utility.

BUG= 724212 
R=ellyjones@chromium.org, mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2897083002
Cr-Commit-Position: refs/heads/master@{#475519}

[delete] https://crrev.com/cf9d12f1999e34f40e9e3ee9e40829d4529cb55b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-basics.html
[modify] https://crrev.com/e11116938aaefd39902c8441f25bd3e230e9c487/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
[modify] https://crrev.com/e11116938aaefd39902c8441f25bd3e230e9c487/third_party/WebKit/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html
[modify] https://crrev.com/e11116938aaefd39902c8441f25bd3e230e9c487/third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html
[delete] https://crrev.com/cf9d12f1999e34f40e9e3ee9e40829d4529cb55b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/interfaces.js

Status: Fixed (was: Assigned)
Mike fixed this :)
Hooray!

Sign in to add a comment