ClangToTWin is red with -Winteger-overflow |
|||
Issue descriptionAll Windows ToT bots look red. From https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/12352: FAILED: obj/gpu/gpu_unittests/gles2_cmd_decoder_unittest_extensions.obj ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/gpu/gpu_unittests/gles2_cmd_decoder_unittest_extensions.obj.rsp /c ../../gpu/command_buffer/service/gles2_cmd_decoder_unittest_extensions.cc /Foobj/gpu/gpu_unittests/gles2_cmd_decoder_unittest_extensions.obj /Fd"obj/gpu/gpu_unittests_cc.pdb" C:\b\c\builder\ClangToTWin\src\gpu\command_buffer\service\gles2_cmd_decoder_unittest_extensions.cc(592,55): error: overflow in expression; result is -2147483648 with type 'int' [-Werror,-Winteger-overflow] delete_cmd.Init(std::numeric_limits<GLsizei>::max() + 1, ^ C:\b\c\builder\ClangToTWin\src\gpu\command_buffer\service\gles2_cmd_decoder_unittest_extensions.cc(778,52): error: overflow in expression; result is -2147483646 with type 'int' [-Werror,-Winteger-overflow] gen_cmd.Init(std::numeric_limits<GLsizei>::max() + 3, ^ C:\b\c\builder\ClangToTWin\src\gpu\command_buffer\service\gles2_cmd_decoder_unittest_extensions.cc(822,55): error: overflow in expression; result is -2147483646 with type 'int' [-Werror,-Winteger-overflow] delete_cmd.Init(std::numeric_limits<GLsizei>::max() + 3, ^ 3 errors generated.
,
May 18 2017
Last good clang: 303305 first bad: 303321
,
May 18 2017
Probably this one: ------------------------------------------------------------------------ r303317 | nicholas | 2017-05-17 16:56:54 -0700 (Wed, 17 May 2017) | 2 lines The constant expression evaluator should examine function arguments for non-constexpr function calls unless the EvalInfo says to stop. ------------------------------------------------------------------------
,
May 18 2017
https://codereview.chromium.org/2892663004 for the three warnings on the bot The non-Windows bots all seem happy so hopefully there isn't much more.
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93304bdb30f35daf45c935a39f23d7277ee6ccfa commit 93304bdb30f35daf45c935a39f23d7277ee6ccfa Author: hans <hans@chromium.org> Date: Thu May 18 21:06:45 2017 Fix signed integer overflow in gles2_cmd_decoder_unittest_extensions.cc New versions of Clang warns about this. BUG= 724186 TBR=jbauman CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2892663004 Cr-Commit-Position: refs/heads/master@{#472932} [modify] https://crrev.com/93304bdb30f35daf45c935a39f23d7277ee6ccfa/gpu/command_buffer/service/gles2_cmd_decoder_unittest_extensions.cc
,
May 18 2017
I was able to complete a full release build locally without warnings, so hopefully these were the only instances. |
|||
►
Sign in to add a comment |
|||
Comment 1 by h...@chromium.org
, May 18 2017