simplechrome: Reboot for D-Bus changes will discard mount-dir |
||||
Issue descriptionFollowing go/simplechrome deploy_chrome --build-dir=out_$SDK_BOARD/Release --to=172.18.37.39 --target-dir=/usr/local/chrome --mount-dir=/opt/google/chrome --nostrip If there are dbus changes, it will automatically reboot the device. But then the device doesn't run the version of chrome you just deployed, since you deployed it to /usr/local/chrome and the bind mount has gone away. The tool should at least print a warning that this happened, or maybe even throw an error. I don't remember who added the dbus detect feature - stevenjb, do you know? Feel free to reassign
,
May 18 2017
Sounds reasonable to me.
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e8c827bbc219725a9341ca1cf495449514567d58 commit e8c827bbc219725a9341ca1cf495449514567d58 Author: Justin TerAvest <teravest@chromium.org> Date: Wed May 24 06:59:11 2017 deploy_chrome: Avoid unnecessary D-Bus reboots. When D-Bus service files in /opt/google/chrome/dbus are updated, we need to trigger a reboot so that dbus-daemon can be set up properly with the new configuration. However, when a user uses the --target-dir option, the D-Bus changes won't be applied, and there is no need to perform the reboot. In that case, a warning message is logged so users are aware in case they expected D-Bus changes to be applied. BUG= chromium:724175 TEST=deploy_chrome with a new dbus file Change-Id: I1be9824881648d2092688b906700ba319b3b713e Reviewed-on: https://chromium-review.googlesource.com/509932 Commit-Ready: Justin TerAvest <teravest@chromium.org> Tested-by: Justin TerAvest <teravest@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/e8c827bbc219725a9341ca1cf495449514567d58/scripts/deploy_chrome.py
,
May 30 2017
This landed in Chrome on May 24: https://codereview.chromium.org/2905543003/
,
Aug 1 2017
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by teravest@chromium.org
, May 18 2017Owner: teravest@chromium.org