New issue
Advanced search Search tips

Issue 724161 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Delete chrome://large-icon

Project Member Reported by pkotw...@chromium.org, May 18 2017

Issue description

chrome://large-icon is no longer useful with the rollout of native history on Android

https://codereview.chromium.org/2830983005 removed last usage
 
CCing kolos@ who said that his team might want to use chrome://large-icon. Will delay removal till we figure whether they actually do
Cc: kolos@chromium.org
Cc: melandory@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4030d6daba664202cae56cdfb0de6da75e9038b

commit e4030d6daba664202cae56cdfb0de6da75e9038b
Author: pkotwicz <pkotwicz@chromium.org>
Date: Tue Jun 06 17:45:11 2017

Remove unused chrome://large-icon

chrome://large-icon is no longer used now that Android uses native UI for
history. References to chrome://large-icon were removed in
https://codereview.chromium.org/2830983005

BUG= 724161 

Review-Url: https://codereview.chromium.org/2917733002
Cr-Commit-Position: refs/heads/master@{#477331}

[modify] https://crrev.com/e4030d6daba664202cae56cdfb0de6da75e9038b/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e4030d6daba664202cae56cdfb0de6da75e9038b/chrome/browser/ui/webui/browsing_history_handler.cc
[delete] https://crrev.com/40c3d19c6990288bb88f28086e088306feae4766/chrome/browser/ui/webui/large_icon_source.cc
[delete] https://crrev.com/40c3d19c6990288bb88f28086e088306feae4766/chrome/browser/ui/webui/large_icon_source.h
[modify] https://crrev.com/e4030d6daba664202cae56cdfb0de6da75e9038b/chrome/common/url_constants.cc
[modify] https://crrev.com/e4030d6daba664202cae56cdfb0de6da75e9038b/chrome/common/url_constants.h
[modify] https://crrev.com/e4030d6daba664202cae56cdfb0de6da75e9038b/components/favicon_base/BUILD.gn
[delete] https://crrev.com/40c3d19c6990288bb88f28086e088306feae4766/components/favicon_base/large_icon_url_parser.cc
[delete] https://crrev.com/40c3d19c6990288bb88f28086e088306feae4766/components/favicon_base/large_icon_url_parser.h
[delete] https://crrev.com/40c3d19c6990288bb88f28086e088306feae4766/components/favicon_base/large_icon_url_parser_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment