New issue
Advanced search Search tips

Issue 724152 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 475060



Sign in to add a comment

Make HttpStreamFactoryImpl::JobController::Start() return an net error code on sync error

Project Member Reported by xunji...@chromium.org, May 18 2017

Issue description

This is to follow up on https://codereview.chromium.org/2814633003/. 
When JobController::Start() fails synchronously, we post task to notify the sync failure so that we can avoid re-entrancy. This is ugly. We should modify the method signature of JobController::Start() to reflect the fact that it can fail synchronously.

 

Comment 1 by b...@chromium.org, May 19 2017

Owner: b...@chromium.org
I'm stealing this bug as discussed with the owner offline.
Bence already has a CL in the works to make the signature more sane. He might be able to put in a fix for this one as well. (Thanks, Bence!)
Components: Internals>Network
Components: -Internals>Network>HTTP

Sign in to add a comment