New issue
Advanced search Search tips

Issue 724146 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 678705



Sign in to add a comment

mash: Remove ash::Shell access from chrome/browser/sync

Project Member Reported by jamescook@chromium.org, May 18 2017

Issue description

Replace with mojo apis. See ash/README.md and go/mustash.

 

Comment 1 by est...@chromium.org, Aug 10 2017

Owner: est...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0daefa1690499699793f6e0535d9b70e887d2aa8

commit 0daefa1690499699793f6e0535d9b70e887d2aa8
Author: Evan Stade <estade@chromium.org>
Date: Fri Aug 11 20:58:03 2017

Remove ash:: references and includes from chrome/browser/sync/

I believe these have been obsolete since ash and chromeos became
synonymous.

Bug:  724146 
Change-Id: Icac2077c91cbb1cc29c2824b5ec34ddd406a3e19
Reviewed-on: https://chromium-review.googlesource.com/610509
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Stanislav Chiknavaryan <stanisc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493850}
[modify] https://crrev.com/0daefa1690499699793f6e0535d9b70e887d2aa8/chrome/browser/sync/DEPS
[modify] https://crrev.com/0daefa1690499699793f6e0535d9b70e887d2aa8/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/0daefa1690499699793f6e0535d9b70e887d2aa8/chrome/browser/sync/sync_error_notifier_ash_unittest.cc
[modify] https://crrev.com/0daefa1690499699793f6e0535d9b70e887d2aa8/chrome/browser/sync/sync_error_notifier_factory_ash.cc

Comment 3 by est...@chromium.org, Sep 12 2017

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment