New issue
Advanced search Search tips

Issue 724143 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 678705



Sign in to add a comment

mash: Remove ash::Shell access from chrome/browser/signin

Project Member Reported by jamescook@chromium.org, May 18 2017

Issue description

Replace with mojo apis. See ash/README.md and go/mustash.

 

Comment 1 by est...@chromium.org, Aug 10 2017

Owner: est...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff

commit c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff
Author: Evan Stade <estade@chromium.org>
Date: Tue Aug 15 22:40:55 2017

Remove ash:: references from chrome/browser/signin

- move devicetype_utils from ash/system/ to ui/chromeos/
- remove some obsolete platform ifdefs for Windows ash support

Bug:  724143 
Change-Id: Ib9ce1b0424448db75f66f7737a04bde148a9861e
Reviewed-on: https://chromium-review.googlesource.com/610702
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494579}
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/ash/BUILD.gn
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/ash/ash_strings.grd
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/ash/display/display_error_observer_chromeos.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/ash/display/display_error_observer_chromeos_unittest.cc
[delete] https://crrev.com/aff275fdb38c8f2e283264bf3bb412d3c7804e9c/ash/system/devicetype_utils.h
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/ash/system/power/tray_power.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/ash/system/screen_layout_observer_unittest.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/chromeos/arc/arc_auth_notification.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/chromeos/arc/arc_migration_guide_notification.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/chromeos/arc/notification/arc_provision_notification_service.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/extensions/api/hotword_private/hotword_private_api.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/extensions/component_loader.cc
[delete] https://crrev.com/aff275fdb38c8f2e283264bf3bb412d3c7804e9c/chrome/browser/signin/DEPS
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/signin/easy_unlock_notification_controller_chromeos.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/signin/easy_unlock_screenlock_state_handler.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/signin/signin_error_notifier_ash.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/signin/signin_error_notifier_ash_unittest.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/signin/signin_error_notifier_factory_ash.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/signin/signin_global_error_factory.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/ui/webui/help/help_handler.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/ui/webui/settings/about_handler.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/ui/chromeos/BUILD.gn
[rename] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/ui/chromeos/devicetype_utils.cc
[add] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/ui/chromeos/devicetype_utils.h
[modify] https://crrev.com/c7b537a12f7f98f3fc3af4de3e6175b5eebe48ff/ui/chromeos/ui_chromeos_strings.grd

Comment 3 by est...@chromium.org, Sep 12 2017

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment