New issue
Advanced search Search tips

Issue 724142 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 678705



Sign in to add a comment

mash: Remove ash::Shell access from chrome/browser/renderer_context_menu

Project Member Reported by jamescook@chromium.org, May 18 2017

Issue description

Replace with mojo apis. See ash/README.md and go/mustash.


 

Comment 1 by est...@chromium.org, Aug 18 2017

Owner: est...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bf35f0eeb70495a7cdb3990adfc9fbe93131926

commit 6bf35f0eeb70495a7cdb3990adfc9fbe93131926
Author: Evan Stade <estade@chromium.org>
Date: Fri Sep 01 01:11:13 2017

Remove ash dependencies from chrome/browser/renderer_context_menu/.

Make the ARC link handler menu builder use components/arc/ directly
instead of routing through ash/.

Bug:  724142 
Change-Id: Ic346fea83c3b7efe41affc753fbc85b1c4afaca5
Reviewed-on: https://chromium-review.googlesource.com/643986
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499096}
[modify] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/ash/BUILD.gn
[delete] https://crrev.com/32e93a5537f28e82120108ef5d0a44ed8c559548/ash/link_handler_model.cc
[delete] https://crrev.com/32e93a5537f28e82120108ef5d0a44ed8c559548/ash/link_handler_model.h
[delete] https://crrev.com/32e93a5537f28e82120108ef5d0a44ed8c559548/ash/link_handler_model_factory.cc
[delete] https://crrev.com/32e93a5537f28e82120108ef5d0a44ed8c559548/ash/link_handler_model_factory.h
[modify] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/ash/shell.cc
[modify] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/ash/shell.h
[modify] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/chrome/browser/BUILD.gn
[modify] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/chrome/browser/chromeos/BUILD.gn
[rename] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/chrome/browser/chromeos/arc/intent_helper/open_with_menu.cc
[rename] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/chrome/browser/chromeos/arc/intent_helper/open_with_menu.h
[rename] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/chrome/browser/chromeos/arc/intent_helper/open_with_menu_unittest.cc
[delete] https://crrev.com/32e93a5537f28e82120108ef5d0a44ed8c559548/chrome/browser/renderer_context_menu/DEPS
[delete] https://crrev.com/32e93a5537f28e82120108ef5d0a44ed8c559548/chrome/browser/renderer_context_menu/open_with_menu_factory.cc
[delete] https://crrev.com/32e93a5537f28e82120108ef5d0a44ed8c559548/chrome/browser/renderer_context_menu/open_with_menu_factory.h
[modify] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/chrome/browser/renderer_context_menu/render_view_context_menu.h
[modify] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/chrome/test/BUILD.gn
[modify] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/components/arc/BUILD.gn
[modify] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/components/arc/intent_helper/arc_intent_helper_bridge.cc
[modify] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/components/arc/intent_helper/arc_intent_helper_bridge.h
[rename] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/components/arc/intent_helper/link_handler_model.cc
[add] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/components/arc/intent_helper/link_handler_model.h
[delete] https://crrev.com/32e93a5537f28e82120108ef5d0a44ed8c559548/components/arc/intent_helper/link_handler_model_impl.h
[rename] https://crrev.com/6bf35f0eeb70495a7cdb3990adfc9fbe93131926/components/arc/intent_helper/link_handler_model_unittest.cc

Comment 3 by est...@chromium.org, Sep 12 2017

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment