New issue
Advanced search Search tips

Issue 724130 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16.8% regression in page_cycler_v2.basic_oopif at 471045:471120

Project Member Reported by tdres...@chromium.org, May 18 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=724130

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg6ryRnwkM


Bot(s) for this bug's original alert(s):

linux-release
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 18 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: linux_perf_bisect
  Benchmark    : page_cycler_v2.basic_oopif
  Metric       : timeToFirstMeaningfulPaint_avg/pcv1-warm/http___www.fifa.com_

Revision             Result                  N
chromium@471044      262.063 +- 113.591      21      good
chromium@471120      254.482 +- 101.882      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...www.fifa.com. page_cycler_v2.basic_oopif

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979246237795401760

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5285753761824768


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, May 18 2017

Cc: thakis@chromium.org
Owner: thakis@chromium.org

=== Auto-CCing suspected CL author thakis@chromium.org ===

Hi thakis@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : thakis
  Commit : 1a94a262a90ca1f0dad5952b021f89628f1c81f7
  Date   : Thu May 11 20:20:45 2017
  Subject: Revert of [PageLoadMetrics] Reenable AdsMetrics and handle case where navigation aborts (patchset #7 id:340001 of https://codereview.chromium.org/2861433005/ )

Bisect Details
  Configuration: linux_perf_bisect
  Benchmark    : page_cycler_v2.basic_oopif
  Metric       : timeToFirstMeaningfulPaint_avg/pcv1-warm/http___www.fifa.com_
  Change       : 7.96% | 263.429571429 -> 284.4085

Revision             Result                  N
chromium@471044      263.43 +- 60.7483       14      good
chromium@471054      256.548 +- 89.6505      14      good
chromium@471055      292.462 +- 102.138      14      bad       <--
chromium@471057      286.208 +- 127.061      21      bad
chromium@471059      284.651 +- 86.9021      14      bad
chromium@471064      294.502 +- 111.355      14      bad
chromium@471082      278.592 +- 93.1039      21      bad
chromium@471120      284.408 +- 94.6107      14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...www.fifa.com. page_cycler_v2.basic_oopif

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979239058035329712

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5285753761824768


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 6 by thakis@chromium.org, May 19 2017

Status: jkarlinchromium.org (was: Untriaged)
That was a revert. I don't know if the original CL relanded. jkarlin fyi that perf infra thinks your change might improve perf.

Comment 7 by hjd@chromium.org, Jul 24 2017

Cc: jkarlin@chromium.org
Labels: -Performance-Sheriff
Status: WontFix (was: jkarlinchromium.org)
Removing Performance-Sheriff: bisected to a revert.

Sign in to add a comment